[ bzflag-Feature Requests-776793 ] Rogues should be YELLOW!

[SourceForge.net <no...@so...>]

Feature Requests item #776793, was opened at 2003-07-24 17:21
Message generated for change (Comment added) made by wallycrooze
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=353248&aid=776793&group_id=3248

Category: None
Group: None
Status: Open
Resolution: None
Priority: 6
Submitted By: Chris Walters (wallycrooze)
Assigned to: Nobody/Anonymous (nobody)
Summary: Rogues should be YELLOW!

Initial Comment:
Rogue tanks are almost impossible to see since they are
black... they should either be yellow... or maybe white
if eventually yellow becomes a team colour.

Rogues are generally individuals that hate being on a
team because of genocide... they shouldn't therefore
benefit from the choice by becoming difficult to see.


----------------------------------------------------------------------

>Comment By: Chris Walters (wallycrooze)
Date: 2003-07-25 11:25

Message:
Logged In: YES 
user_id=530199

This is a simple fix... but one question arises... why is
_color being overriden by a local "rogueColor" rather than
the system one, in the first place?

Index: src/common/Team.cxx
===================================================================
RCS file: /cvsroot/bzflag/bzflag/src/common/Team.cxx,v
retrieving revision 1.4.2.5
diff -r1.4.2.5 Team.cxx
18,22c18,22
<                               { 0.0f, 0.0f, 0.0f },
<                               { 1.0f, 0.0f, 0.0f },
<                               { 0.0f, 1.0f, 0.0f },
<                               { 0.2f, 0.2f, 1.0f },
<                               { 1.0f, 0.0f, 1.0f }
---
>                               { 1.0f, 1.0f, 0.0f },   // rogue
>                               { 1.0f, 0.0f, 0.0f },   // red
>                               { 0.0f, 1.0f, 0.0f },   // green
>                               { 0.2f, 0.2f, 1.0f },   // blue
>                               { 1.0f, 0.0f, 1.0f }    //
purple
25,27c25,27
<                               { 1.0f, 1.0f, 0.0f }, // rogue
<                               { 1.0f, 0.15f, 0.15f }, //red
<                               { 0.2f, 0.9f, 0.2f }, //green
---
>                               { 1.0f, 1.0f, 0.0f },   // rogue
>                               { 1.0f, 0.15f, 0.15f }, // red
>                               { 0.2f, 0.9f, 0.2f },   // green
29c29
<                               { 1.0f, 0.4f, 1.0f } //purple
---
>                               { 1.0f, 0.4f, 1.0f }    //
purple
Index: src/bzflag/Player.cxx
===================================================================
RCS file: /cvsroot/bzflag/bzflag/src/bzflag/Player.cxx,v
retrieving revision 1.5.2.8
diff -r1.5.2.8 Player.cxx
147c147
<   static const float  rogueColor[3] = { 0.25f, 0.25f, 0.25f };
---
> //   static const float       rogueColor[3] = { 0.25f,
0.25f, 0.25f };
153,154c153,155
<   const float* _color = (team == RogueTeam) ? rogueColor :
<                                              
Team::getTankColor(team);
---
> //   const float* _color = (team == RogueTeam) ? rogueColor :
> //                                           
Team::getTankColor(team);
>   const float* _color = Team::getTankColor(team);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=353248&aid=776793&group_id=3248