Menu

#58 mhop discards out of order pkts

open
nobody
btnut (45)
5
2006-06-08
2006-03-29
No

in mhop_cl.c in the data callback we have:

if (((_mhop_cl_stack.fwdtable[i].seq - src_seq) % (1 <<
sizeof(src_seq)*8))) <= MHOP_CL_BC_WINDOW){
// discard pkt
}

meaning that it discards all pkts that are older than
the last sucessfully received (fwdtable[].seq) up to
MHOP_CL_BC_WINDOW (=64). The idea was to discard the
last 64 pkts.

This is ok if the out of order pkts are only duplicates
e.g. recv. order : 1,1 or 1,2,1

however, if a pkt with a higher seq-nr is received
first (2,1) the one with the lower nr. (1) will be
discarded even if it is not a duplicate.

Possible solution:
instead of having only one entry in fwdtable[].seq, we
could remember simply the last N received seq-numbers
per source to identify duplicates.

Discussion

  • Jan Beutel

    Jan Beutel - 2006-04-26
    • priority: 5 --> 8
     
  • Jan Beutel

    Jan Beutel - 2006-04-28
    • priority: 8 --> 5
     
  • Kevin Martin

    Kevin Martin - 2006-06-08
    • assigned_to: nobody --> kevmarti
     
  • Jan Beutel

    Jan Beutel - 2006-06-08
    • assigned_to: kevmarti --> nobody