Menu

#474 Boolean evaluation of CSG in OpenCL

Incomplete
closed-accepted
None
5
2017-08-23
2017-08-17
No

This patch contains the code to perform boolean evaluation of CSG in OpenCL and was created against the trunk. Changes in the host code should be inside a '#ifdef OPENCL' block.

1 Attachments

Discussion

  • Marco da Silva Domingues

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1 @@
    -This patch contains the code to perform boolean evaluation of CSG in OpenCL and was taken against the trunk. Changes in the host code should be inside a '#ifdef OPENCL' block.
    +This patch contains the code to perform boolean evaluation of CSG in OpenCL and was created against the trunk. Changes in the host code should be inside a '#ifdef OPENCL' block.
    
     
  • Marco da Silva Domingues

    Merging issues when applying previous patch? Should be fixed now

     
    • Vasco Alexandre da Silva Costa

      Ok, I read the patch, and made these changes:
      - renamed structs from clt_ to cl_ to fit the style of the existing
      declarations.
      - changed things like sizeof(cl_int) to sizeof(*array) to reduce the chance
      for errors with future code changes.

      The patch has been commited to trunk/.

      Also, trunk/ doesn't compile with my version of GCC. I got a compile error
      because of some variable being used without initialized properly here:

      Index: ../src/librt/primitives/annot/annot.c

      --- ../src/librt/primitives/annot/annot.c (revision 70098)
      +++ ../src/librt/primitives/annot/annot.c (working copy)
      @@ -333,6 +333,7 @@
      VSETALL(semi_a, 0);
      VSETALL(semi_b, 0);
      VSETALL(center, 0);
      + VSETALL(start_pt, 0);

       lng = (uint32_t *)seg;
       switch (*lng) {
      

      This seems to fix the error, but since I don't know this code that well I
      did not apply this change.

      On Fri, Aug 18, 2017 at 5:29 PM, Marco da Silva Domingues mdtwenty@users.sf.net wrote:

      Merging issues when applying previous patch? Should be fixed now

      Attachments:


      Status: open
      Group: Incomplete
      Created: Thu Aug 17, 2017 11:10 AM UTC by Marco da Silva Domingues
      Last Updated: Thu Aug 17, 2017 11:11 AM UTC
      Owner: Vasco Alexandre da Silva Costa
      Attachments:

      This patch contains the code to perform boolean evaluation of CSG in
      OpenCL and was created against the trunk. Changes in the host code should
      be inside a '#ifdef OPENCL' block.


      Sent from sourceforge.net because you indicated interest in
      https://sourceforge.net/p/brlcad/patches/474/

      To unsubscribe from further messages, please visit
      https://sourceforge.net/auth/subscriptions/

      --
      Vasco Alexandre da Silva Costa
      PhD in Computer Engineering (Computer Graphics)
      Instituto Superior Técnico/University of Lisbon, Portugal

       
  • Vasco Alexandre da Silva Costa

    • status: open --> closed-accepted
     

Log in to post a comment.