This patch contains the code to perform boolean evaluation of CSG in OpenCL and was created against the trunk. Changes in the host code should be inside a '#ifdef OPENCL' block.
--- old+++ new@@ -1 +1 @@-This patch contains the code to perform boolean evaluation of CSG in OpenCL and was taken against the trunk. Changes in the host code should be inside a '#ifdef OPENCL' block.+This patch contains the code to perform boolean evaluation of CSG in OpenCL and was created against the trunk. Changes in the host code should be inside a '#ifdef OPENCL' block.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ok, I read the patch, and made these changes:
- renamed structs from clt_ to cl_ to fit the style of the existing
declarations.
- changed things like sizeof(cl_int) to sizeof(*array) to reduce the chance
for errors with future code changes.
The patch has been commited to trunk/.
Also, trunk/ doesn't compile with my version of GCC. I got a compile error
because of some variable being used without initialized properly here:
Status: open Group: Incomplete Created: Thu Aug 17, 2017 11:10 AM UTC by Marco da Silva Domingues Last Updated: Thu Aug 17, 2017 11:11 AM UTC Owner: Vasco Alexandre da Silva Costa Attachments:
This patch contains the code to perform boolean evaluation of CSG in
OpenCL and was created against the trunk. Changes in the host code should
be inside a '#ifdef OPENCL' block.
Diff:
Merging issues when applying previous patch? Should be fixed now
Ok, I read the patch, and made these changes:
- renamed structs from clt_ to cl_ to fit the style of the existing
declarations.
- changed things like sizeof(cl_int) to sizeof(*array) to reduce the chance
for errors with future code changes.
The patch has been commited to trunk/.
Also, trunk/ doesn't compile with my version of GCC. I got a compile error
because of some variable being used without initialized properly here:
Index: ../src/librt/primitives/annot/annot.c
--- ../src/librt/primitives/annot/annot.c (revision 70098)
+++ ../src/librt/primitives/annot/annot.c (working copy)
@@ -333,6 +333,7 @@
VSETALL(semi_a, 0);
VSETALL(semi_b, 0);
VSETALL(center, 0);
+ VSETALL(start_pt, 0);
This seems to fix the error, but since I don't know this code that well I
did not apply this change.
On Fri, Aug 18, 2017 at 5:29 PM, Marco da Silva Domingues mdtwenty@users.sf.net wrote:
--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior Técnico/University of Lisbon, Portugal