Unfortunately it doesn't compile on my computer. Problem is the freewrl libryrary. It doesn't work with an installed libxml2. Your first version (https://github.com/djkonro/GSoC2015/blob/master/freewrl.patch) was better. Maybe you should consider using FindLibXml2 and ${LIBXML2_INCLUDE_DIR} in the CMakeLists.txt.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Unfortunately it doesn't compile on my computer. Problem is the freewrl
libryrary. It doesn't work with an installed libxml2. Your first version ( https://github.com/djkonro/GSoC2015/blob/master/freewrl.patch) was
better. Maybe you should consider using FindLibXml2 and
${LIBXML2_INCLUDE_DIR} in the CMakeLists.txt.
Status: open Group: Incomplete Created: Fri Jul 31, 2015 12:26 PM UTC by Djimeli Konrad Last Updated: Fri Jul 31, 2015 12:26 PM UTC Owner: Daniel Roßberg Attachments:
I'm getting the following compilation errors:
/home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.c: In function ‘parse_node’:
/home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.c:74:12: error: passing argument 1 of ‘do_color’ from incompatible pointer type
do_color(node , X3D_SHAPE(node)->geometry);
^
In file included from /home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.c:34:0:
/home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.h:44:6: note: expected ‘struct X3D_Shape ’ but argument is of type ‘struct X3D_Node ’
void do_color(struct X3D_Shape snode, struct X3D_Node node);
^
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry I did not catch this issue while compiling, but it can be resolved
by casting or applying this patch. After all this minor changed I would
have to submit an improved version of the x3d patch say
x3d_importer_v2.patch.
The following patches are for updated versions of x3d_importer_v1.patch,
freewrl_v1.patch and the x3d-g manual. They do not require any previous
version to be applied since they already everything.
FreeWRL library. This is a companion patch to the one above, which needs to
applied to get the converter working.
FreeWRL library. This is a companion patch to the one above, which needs to
applied to get the converter working.
Last edit: Djimeli Konrad 2015-07-31
Unfortunately it doesn't compile on my computer. Problem is the freewrl libryrary. It doesn't work with an installed libxml2. Your first version (https://github.com/djkonro/GSoC2015/blob/master/freewrl.patch) was better. Maybe you should consider using FindLibXml2 and ${LIBXML2_INCLUDE_DIR} in the CMakeLists.txt.
This patch to fixes the link issue with libxml
On 3 August 2015 at 15:10, "Daniel Roßberg" d_rossberg@users.sf.net wrote:
Related
Patches: #394
Last edit: Djimeli Konrad 2015-08-11
This patch fixes the link issue with libxml
I'm getting the following compilation errors:
/home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.c: In function ‘parse_node’:
/home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.c:74:12: error: passing argument 1 of ‘do_color’ from incompatible pointer type
do_color(node , X3D_SHAPE(node)->geometry);
^
In file included from /home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.c:34:0:
/home/rossberg/Devel/BRL-CAD/brlcad/src/conv/web3d/FREEWRLWrapper.h:44:6: note: expected ‘struct X3D_Shape ’ but argument is of type ‘struct X3D_Node ’
void do_color(struct X3D_Shape snode, struct X3D_Node node);
^
Sorry I did not catch this issue while compiling, but it can be resolved
by casting or applying this patch. After all this minor changed I would
have to submit an improved version of the x3d patch say
x3d_importer_v2.patch.
Last edit: Djimeli Konrad 2015-08-05
The following patches are for updated versions of x3d_importer_v1.patch,
freewrl_v1.patch and the x3d-g manual. They do not require any previous
version to be applied since they already everything.
Last edit: Djimeli Konrad 2015-08-21
Updated code, plus sample x3d files.
Last edit: Djimeli Konrad 2016-04-17