This is conceptually a sound direction, but the patch itself is more of a work-in-progress than a committable incremental improvement. Having a new callback parameter with some NULL and some not is a recipe for bad things to happen. Having a macro named MY_*() isn't something we should publish. Removing const from argv parameters seems unnecessary (we want to ADD const more).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This is conceptually a sound direction, but the patch itself is more of a work-in-progress than a committable incremental improvement. Having a new callback parameter with some NULL and some not is a recipe for bad things to happen. Having a macro named MY_*() isn't something we should publish. Removing const from argv parameters seems unnecessary (we want to ADD const more).