I have refactored dm-generic.c so that it does not contain any functions with #ifdefs. I have only refactored X_open_dm for the moment.
This is conceptually a sound direction, but the patch itself is more of a work-in-progress than a committable incremental improvement. Having a new callback parameter with some NULL and some not is a recipe for bad things to happen. Having a macro named MY_*() isn't something we should publish. Removing const from argv parameters seems unnecessary (we want to ADD const more).
Log in to post a comment.