#179 Refactor X_open_dm from dm-generic.c

Incomplete
closed-rejected
None
5
2013-06-19
2013-05-16
No

I have refactored dm-generic.c so that it does not contain any functions with #ifdefs. I have only refactored X_open_dm for the moment.

1 Attachments

Discussion

  • Sean Morrison

    Sean Morrison - 2013-06-19

    This is conceptually a sound direction, but the patch itself is more of a work-in-progress than a committable incremental improvement. Having a new callback parameter with some NULL and some not is a recipe for bad things to happen. Having a macro named MY_*() isn't something we should publish. Removing const from argv parameters seems unnecessary (we want to ADD const more).

     
  • Sean Morrison

    Sean Morrison - 2013-06-19
    • status: open --> closed-rejected
    • assigned_to: Sean Morrison
     

Log in to post a comment.