Menu

#168 Surface, volume and centroid functions for the pipe primitive

Incomplete
closed-accepted
None
5
2013-07-17
2013-04-22
Csaba Nagy
No

This patch adds surface, volume and centroid calculation functions to the pipe primitive, and augments the analyze command to display them.

As a side effect, all primitives which have a centroid function and use the generic analyze method, will also have the centroid displayed.

I really tried to have the indentation right - hope this time I actually managed it...

Cheers,
Csaba

Discussion

  • Csaba Nagy

    Csaba Nagy - 2013-04-22

    The actual code changes.

     
  • Sean Morrison

    Sean Morrison - 2013-07-17

    Csaba, this is truly awesome. Apologies on taking so long to get to your patch review, but this work is really pretty impressive. Nice work!

    Your patch was applied in r56077. The only problem I noticed is that you printed the centroid in mm instead of the current working units, but that was an easy fix. You've got two news credits for adding the pipe analyze support but also for enabling centroid reporting as well. Thanks for your efforts and hope you have more awesome like this.

     
  • Sean Morrison

    Sean Morrison - 2013-07-17
    • status: open --> closed-accepted
    • assigned_to: Sean Morrison
     

Log in to post a comment.