Re: [brlcad-devel] Volume/Surface of hollow objects

[Christopher S. M. <br...@ma...>]

Csaba,

Thank you for the work you did.  Really awesome.  Comments in following below.

On Apr 28, 2013, at 12:46 PM, Csaba Nagy wrote:

> In case you haven't noticed already, I uploaded the patch with the
> surface, volume and centroid functions for the pipe primitive to the
> analyze command.
> 
> I suppose the GSOC has priority because of deadlines, but I also would
> like to get some feedback for this patch:

Actually, release preparations are what had top priority over the past three months.  We almost didn't participate in GSoC because of it but several mentors stepped forward to participate.

Otherwise, I excitedly noticed your patch right away and it was committed a few days ago.  It looked perfect, applied cleanly, and passed all the simple tests I threw at it.  It'll be in our upcoming release notes for the 7.24.2 release at the end of this month.  

> I have the pipe length function also ready, but left it out to keep the
> patch smaller.

Ready for it! :)

> To facilitate introducing new elements to be displayed by the analyze
> command, I would also like to discuss possible refactoring of the
> analyze.c code to split it in model/view structure, where the model is
> filled by the primitives, and the analyze command is just one of the
> possible views. I do think about another view for populating TCL
> variables in mged.

Clean-up work like that is always more than welcome.  I'd even be glad to help.

With as much code as we move around and manage, there's always useful refactoring that is needed (especially app-to-libged and libged-to-librt, sometimes even down to libbu/libbn).

Cheers!
Sean