[brlcad-tracker] [Google Code-in 2012] New comment on Implement thread creation for Windows

[<no-...@go...>]

Hi,


Sean has left the following comment at Implement thread creation for  
Windows http://www.google-melange.com/gci/task/view/google/gci2012/8030203:


few issues


Adrián, that's looking good but I noticed a few problems. The biggest is  
that you need to wait for all threads to complete before allowing the  
bu_parallel() function to return. Something similar to pthread_join(). See  
the other sections for examples.

Another problem is the formatting is a terrible mess! :) Your indentation  
doesn't follow our coding style (please read our HACKING file). Indentation  
needs to be pristine and matching the rest of the file. Indents should be 4  
char, 1 tab, 1 tab + 4 char, 2 tab, 2 tab + 4 char, etc. There shouldn't be  
a slew of empty blank lines, there shouldn't be XXX comments for new code.  
Formatting isn't just nice to have -- it's just as important as the code  
itself so please work to get it right.

Finally, what are the pDataArray values supposed to mean? I see the first  
is the cpu number, but why is the second incremented by 100?


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Implement  
thread creation for Windows.
To stop receiving these messages, go to:  
http://www.google-melange.com/gci/task/view/google/gci2012/8030203.