[brlcad-tracker] [ brlcad-Patches-3534954 ] Refactoring in fb/pl-fb.c

[SourceForge.net <no...@so...>]

Patches item #3534954, was opened at 2012-06-13 11:31
Message generated for change (Comment added) made by ksuzee
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3534954&group_id=105292

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ksenija Slivko (ksuzee)
Assigned to: Nobody/Anonymous (nobody)
Summary: Refactoring in fb/pl-fb.c

Initial Comment:
static inline int dCoords function is added. It's called in GetDCoords and Get3DCoords. They're different because of the parameter of fprintf, so it is put as a parameter of function. Making is successful all printfs with char * are tested.

----------------------------------------------------------------------

>Comment By: Ksenija Slivko (ksuzee)
Date: 2012-07-30 10:22

Message:
Alternative links : http://rghost.ru/39484876.view and
http://rghost.ru/39485002.view

----------------------------------------------------------------------

Comment By: Ksenija Slivko (ksuzee)
Date: 2012-07-30 00:49

Message:
Patch was updated. Logic didn't changed. You can look here
https://dl-web.dropbox.com/get/Public/diff.png?w=4a6da7f8 (initial
difference between GetDCoords and Get3DCoords). There were three different
places (depence on dimensional). After reduction :
https://dl-web.dropbox.com/get/Public/fb_after.png?w=8b791007 ("in" now
parameter). Everything is clear now.

----------------------------------------------------------------------

Comment By: Cliff Yapp (starseeker)
Date: 2012-07-29 14:03

Message:
I'm still seeing this patch remove the fread from GetDCoords, as well as
some assignment logic - is that intentional?  It looks like only lines 869
- 872 should be impacted by this, but the whole body of GetDCoords is
pretty much gutted.

----------------------------------------------------------------------

Comment By: Ksenija Slivko (ksuzee)
Date: 2012-07-28 11:31

Message:
Patch was updated.

----------------------------------------------------------------------

Comment By: Cliff Yapp (starseeker)
Date: 2012-07-24 19:06

Message:
Ksenija - the fread was removed from the function in this patch, as well as
the assignments to coop - is that intentional?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3534954&group_id=105292