[brlcad-tracker] [ brlcad-Patches-3529861 ] reduction for util/lowp.c and rt/viewarea.c

[SourceForge.net <no...@so...>]

Patches item #3529861, was opened at 2012-05-25 15:04
Message generated for change (Settings changed) made by ksuzee
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529861&group_id=105292

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ksenija Slivko (ksuzee)
Assigned to: Nobody/Anonymous (nobody)
Summary: reduction for util/lowp.c and rt/viewarea.c

Initial Comment:
Now there's function check_readval()  in lowp.c, which contains commom code (I speaked about it with Sean).
Also in viewarea.c is set_factor() which returns the resalt of bu_units_conversion().

----------------------------------------------------------------------

Comment By: Ksenija Slivko (ksuzee)
Date: 2012-05-31 08:38

Message:
I've tested lowp with the same data before and after - result is the same
too. So lowp reduction must be correct

----------------------------------------------------------------------

Comment By: Sean Morrison (brlcad)
Date: 2012-05-25 15:08

Message:
Did you test the lowp change (by actually running the lowp command on some
data)?

You don't have to separate these two, but for future reference you should
separate different patches to different tracker items (just like they
should be separate commits).  Nice progress!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529861&group_id=105292