[brlcad-tracker] [ brlcad-Patches-3528636 ] /libbu/convert.c

[SourceForge.net <no...@so...>]

Patches item #3528636, was opened at 2012-05-21 10:27
Message generated for change (Settings changed) made by brlcad
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3528636&group_id=105292

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: Untested
>Status: Pending
>Resolution: Postponed
Priority: 5
Private: No
Submitted By: Ksenija Slivko (ksuzee)
>Assigned to: Sean Morrison (brlcad)
Summary: /libbu/convert.c

Initial Comment:
This patch is similar to /libbu/htonf.c. There's a couple of the same situations in convert.c. I did the same as in the previous: some static inline functions. However, I'm not sure about the names of functions and converting from unsigned short int* pointers to just short int*. Check it please, because there's some similar situations in this file.

----------------------------------------------------------------------

>Comment By: Sean Morrison (brlcad)
Date: 2012-05-27 21:18

Message:
Without a unit test for convert.c, I'm cautious that this refactoring
doesn't introduce some subtle problem casting between signed and unsigned
data.  It could potentially introduce a rather obscure bug.

The change probably warranted a little discussion before tackling it, but
the code itself and refactoring are fine.  It just means this patch cannot
be reasonably applied without either manual or unit testing.  Did you test
this change?



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3528636&group_id=105292