[brlcad-tracker] [ brlcad-Patches-3529861 ] reduction for util/lowp.c and rt/viewarea.c
Open Source Solid Modeling CAD
Brought to you by:
brlcad
From: SourceForge.net <no...@so...> - 2012-05-25 22:08:39
|
Patches item #3529861, was opened at 2012-05-25 15:04 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529861&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Ksenija Slivko (ksuzee) Assigned to: Nobody/Anonymous (nobody) Summary: reduction for util/lowp.c and rt/viewarea.c Initial Comment: Now there's function check_readval() in lowp.c, which contains commom code (I speaked about it with Sean). Also in viewarea.c is set_factor() which returns the resalt of bu_units_conversion(). ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2012-05-25 15:08 Message: Did you test the lowp change (by actually running the lowp command on some data)? You don't have to separate these two, but for future reference you should separate different patches to different tracker items (just like they should be separate commits). Nice progress! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3529861&group_id=105292 |