[brlcad-commits] SF.net SVN: brlcad:[50076] brlcad/trunk/src/mged/animedit.c

[<br...@us...>]

Revision: 50076
          http://brlcad.svn.sourceforge.net/brlcad/?rev=50076&view=rev
Author:   brlcad
Date:     2012-04-16 14:36:42 +0000 (Mon, 16 Apr 2012)
Log Message:
-----------
looks like coverity deadcode defect CID 214 is a false positive, complaining about curfound being always true, but try to be explicit anyways for code clarity.  move the initial false case init out to the loop so it's clear that it starts false.

Modified Paths:
--------------
    brlcad/trunk/src/mged/animedit.c

Modified: brlcad/trunk/src/mged/animedit.c
===================================================================
--- brlcad/trunk/src/mged/animedit.c	2012-04-16 14:20:10 UTC (rev 50075)
+++ brlcad/trunk/src/mged/animedit.c	2012-04-16 14:36:42 UTC (rev 50076)
@@ -862,7 +862,7 @@
 parse_trans(struct joint *jp, int idx, FILE *fip, struct bu_vls *str)
 {
     union bu_lex_token token;
-    int dirfound=0, upfound = 0, lowfound=0, curfound=0;
+    int dirfound, upfound, lowfound, curfound;
 
     if (joint_debug & DEBUG_J_PARSE) {
 	Tcl_AppendResult(INTERP, "parse_trans: open\n", (char *)NULL);
@@ -876,6 +876,7 @@
     }
     if (!gobble_token(BU_LEX_SYMBOL, SYM_OP_GROUP, fip, str)) return 0;
 
+    dirfound = upfound = lowfound = curfound = 0;
     while (get_token(&token, fip, str, animkeys, animsyms) != EOF) {
 	if (token.type == BU_LEX_IDENT) {
 	    bu_free(token.t_id.value, "unit token");
@@ -907,7 +908,8 @@
 		parse_error(str, "parse_trans: lower > upper, exchanging.");
 	    }
 	    jp->dirs[idx].accepted = 0.0;
-	    if (!curfound) jp->dirs[idx].current = 0.0;
+	    if (!curfound)
+		jp->dirs[idx].current = 0.0;
 	    jp->dirs[idx].lower *= base2mm;
 	    jp->dirs[idx].upper *= base2mm;
 	    jp->dirs[idx].current *= base2mm;
@@ -1020,7 +1022,7 @@
 parse_rots(struct joint *jp, int idx, FILE *fip, struct bu_vls *str)
 {
     union bu_lex_token token;
-    int dirfound=0, upfound = 0, lowfound=0, curfound=0;
+    int dirfound, upfound, lowfound, curfound;
 
     if (joint_debug & DEBUG_J_PARSE) {
 	Tcl_AppendResult(INTERP, "parse_rots: open\n", (char *)NULL);
@@ -1034,6 +1036,7 @@
     }
     if (!gobble_token(BU_LEX_SYMBOL, SYM_OP_GROUP, fip, str)) return 0;
 
+    dirfound = upfound = lowfound = curfound = 0;
     while (get_token(&token, fip, str, animkeys, animsyms) != EOF) {
 	if (token.type == BU_LEX_IDENT) {
 	    bu_free(token.t_id.value, "unit token");
@@ -1335,7 +1338,7 @@
 parse_jset(struct hold *hp, FILE *fip, struct bu_vls *str)
 {
     union bu_lex_token token;
-    int jointfound=0, listfound=0, arcfound=0, pathfound=0;
+    int jointfound, listfound, arcfound, pathfound;
 
     if (joint_debug & DEBUG_J_PARSE) {
 	Tcl_AppendResult(INTERP, "parse_jset: open\n", (char *)NULL);
@@ -1343,6 +1346,7 @@
 
     if (!gobble_token(BU_LEX_SYMBOL, SYM_OP_GROUP, fip, str)) return 0;
 
+    jointfound = listfound = arcfound = pathfound = 0;
     for (;;) {
 	if (get_token(&token, fip, str, animkeys, animsyms) == EOF) {
 	    parse_error(str, "parse_jset: Unexpect EOF getting contents of joint set");

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.