|
From: brlcad <br...@ma...> - 2012-04-11 15:01:08
|
On Apr 11, 2012, at 08:42 AM, Tom Browder <tom...@gm...> wrote: Though it's not exactly the same as a full dup code look, I did grep the src for get_int, getint, get_double, and getdouble and found no other instances. Mmm. I'd wager they're just named something else. I know I've changed a few as I've run across them, or maybe only a couple instances remaining. There are standard C functions for exactly what those functions do, though: strtod(), strtol(). Vdeck's implementation actually just predates their standardization as part of C90 by a few years. I'd cut Doug Gwyn a little bit of slack if it weren't for the other (terrible) coding conventions he used back then... ;) There are other functions in comgeom (tools.c and f2a.c) that look like they belong in libbu. There are standard C functions (and libbn/vmath) functions for most of those too. f2a() can probably be replaced with snprintf(). Cheers! Sean |