#537 Compilation failure in cdrom_osx.cc

[FX]

Compilation with Xcode 9 on macOS 10.13 fails with:

cdrom_osx.cc:194:18: error: assigning to 'char ' from incompatible type 'const char '
if ((devname = strrchr(devpath, '/')) != NULL) {
^~~~~~~~~~~~~~~~~~~~~

(full log available at https://gist.githubusercontent.com/anonymous/c5b541ed9435c86a2a18f035426e8ede/raw/366f5910caba00c923783adb46d33f76f7aa6ca3/02.make)

strrchr() with a const char * argument returns a const char * result, which needs to be cast to char *.

Patch is available at: https://raw.githubusercontent.com/Homebrew/formula-patches/e9b520dd4c/bochs/xcode9.patch

[Volker Ruppert]

The bug has been fixed in SVN in a different way. Can you confirm that it's okay now?

[Volker Ruppert]

No response, closing this item.