Hi Oliver, first of all, thank you for your work. I like to use Blufish under KDE (Plasma). I have compiled 2.4.0 and the same as in the previous versions. Rendering with GTK3 looks great, almost like QT-native. Dark/Light switching works without any problems.
Icons are a bit problematic though. By default, they are gnome icons. OK. However, system icons are installed in the toolbar and in some menu items (GTK_STOCK...). That's all very well.
Breeze icons are used by default in KDE. So it is problematic because Breeze and Gnome icons (Adwaita?) do not fit together at all. The solution is, you can replace and recompile the graphics in the sources. Breeze usually only uses monochrome icon icons. If you compile Light and switch the interface to Dark, you don't see anything. It's about the icons in the toolbar and snipping tool.
See the screenshots.
It shuld be so https://specifications.freedesktop.org/icon-theme/latest/
The best way is the outsourcing of icons:
/usr/share/bluefish/icons
/usr/share/bluefish/icons/gnome/
/usr/share/bluefish/icons/breeze/
/usr/share/bluefish/icons/breeze-dark
and in user directory we can play with the iconc. ~/.config/share/bluefisf/icons
I have created Breeze icons for Bluefish (dark and light), you can use this for testing and implementation.
Can you implement this one day? :-)
Question: why are the icons included in C-code with gdk-pixbuf?
greetings byDMA
the provided icons look nice. The drawback is that we have to maintain three sets of icons, (or maybe 4 if we also create gnome-dark icons).
the icons are compiled to C-code because this speeds up the startup of Bluefish. Since Bluefish has a lot of icons, a file lookup for each icon means 50 files that need to be read, converted from their compressed format into a pixbuf, and rendered to screen. The icons that are compiled to c-code are already compiled into a pixbuf, so they can be rendered to screen immediately without any need for file open or decompression.