Menu

#327 wrong file extension when saving files - complete data loss

v_0.9.0
closed
None
9
2012-09-12
2009-06-03
Uwe
No

In
https://sourceforge.net/tracker/?func=detail&aid=2798148&group_id=165310&atid=835077
you told me that I should reopen the bug when I see the problem in 0.9.5 but you forbid me to do this, I cannot even add a comment.

So next try:

create a new file and draw e.g. methane

  • save the file as "methane.cml"

Result: Avogadro saves the file as "methane.cml.old" instead of "methane.cml". But this file cannot be opened by any program, because "old" is not a vlid file extension.

I'm using Avogadro 0.9.5 under Windows.

Discussion

  • Marcus D. Hanwell

    I did not forbid anything... Sounds like it is the SF bug tracker and I have limited control over their implementation. I thought the user that opened a bug report could also reopen it, that may not be the case.

    It looks like the new logic does not work as well as expected on Windows and we are currently working on a fix. I can reproduce it and have what looks like a working binary. I will do some further testing and hopefully upload something later today. It looks like this bug is very Windows specific.

     
  • Uwe

    Uwe - 2009-06-03

    I thought the user that opened a bug report could also reopen it, that may not be the case.

    This was possible with the old SF tracker - I guess you have to specify some tracker settings by your own. As I understood it, SF's new tracker only provides very basic features by default, for all other tracker settings, the projects leaders (you) can decide what should be allowed or not in the tracker.

    I can reproduce it

    Don't take this personally, but why have you released it then?
    I'm a developer of www.lyx.org and there we have a testing procedure before every release:

    • saving, save as, opening, closing, drag'n drop, image insertion, spell-checker, ...
    • testing the installer for Mac and Windows
    • testing the installation on Unix, Win, Mac
      This way it is assured that every basic feature will work. We also have some test files that we open and play a bit with to find bugs.
     
  • Marcus D. Hanwell

    I will look in to the settings once I have some spare time. Please do not take this personally, but your comments could be a lot more constructive. I discovered the bug after we made the release, I will add some further points to test before release on the checklist. I generally test opening some files, different display types, settings, and several other parts of the interface and must have forgotten to test saving.

    I agree that we should make efforts to ensure core functionality works as expected. This one slipped through on Windows, sorry about that. It was an honest mistake. I am working on a fix and hope to have a new binary soon, but am taking a little longer on this one and also trying to fix another file reading issue.

     
  • Marcus D. Hanwell

    If you would like to test a new binary, then I have a test one. It is at http://blog.cryos.net/uploads/Avogadro-0.9.5-win32b.exe if you would like to test it. I think we still need to convert line endings of the fragments, but other than that it seems OK. I will likely upload this later today. We will more than likely make a 0.9.6 release in a week or two.

     
  • Marcus D. Hanwell

    Marking this as fixed - files are now saved correctly in the updated windows binaries. We can discuss the other issues on the mailing list or in a separate bug. We have multiple reports on both XP and Vista that this issue has been resolved in both the binaries currently available on SF (since yesterday). Looks line the file reading line ending issue (fails to read Unix file endings) may be fixed also. If so we will update the binaires - it requires a small patch to OpenBabel.

     
MongoDB Logo MongoDB