Re: [Audacity-quality] Debugging Assert Problem in 3.0.3 Build: e83210

[David B. <drb...@gm...>]

On Wed, 23 Jun 2021 at 02:48, Cliff <fly...@gm...> wrote:

> David,
>
> I checked and I am building a release version. If the message should only
> come up when running a debug build why did it come up for me. Can I assume
> this is an error?
>

Given that Steve can't reproduce the error on macOS, it would be worth you
checking a recent build on Github, to check that there isn't an issue with
your build. For example:
https://github.com/audacity/audacity/actions/runs/950782778

David.


>
> Cliff
>
> On Jun 22, 2021, at 04:57, David Bailes <drb...@gm...> wrote:
>
> On Tue, 22 Jun 2021 at 10:33, Steve Fiddle <ste...@gm...>
> wrote:
>
>> Testing on both macOS and Linux:
>> I don't see a crash or warning on either machine, but also I don't hear a
>> beep on completion of longer activities.
>> I don't normally have that option enabled and I don't know if it has ever
>> worked.
>>
>
> wxFAIL_MSG() is only called in debug versions.
>
> David.
>
>
>>
>> Steve
>>
>> On Tue, 22 Jun 2021 at 10:13, Steve Fiddle <ste...@gm...>
>> wrote:
>>
>>>
>>>
>>> On Tue, 22 Jun 2021 at 09:49, David Bailes <drb...@gm...> wrote:
>>>
>>>> Hi Cliff,
>>>> I think that there is a problem here, but not sure why it's not been
>>>> showing up before.
>>>> This is the code for osx that's being called:
>>>>
>>>> bool wxSound::Create(size_t WXUNUSED(size), const void* WXUNUSED(data))
>>>> {
>>>>     wxFAIL_MSG( "not implemented" );
>>>>
>>>>     return false;
>>>> }
>>>>
>>>> which is called from:
>>>> void ProgressDialog::Beep() const
>>>> {
>>>>    int after;
>>>>    bool should;
>>>>    wxString name;
>>>>
>>>>    gPrefs->Read(wxT("/GUI/BeepOnCompletion"), &should, false);
>>>>    gPrefs->Read(wxT("/GUI/BeepAfterDuration"), &after, 60);
>>>>    gPrefs->Read(wxT("/GUI/BeepFileName"), &name, wxEmptyString);
>>>>
>>>>    if (should && wxGetUTCTimeMillis().GetValue() - mStartTime > after *
>>>> 1000)
>>>>    {
>>>>       wxBusyCursor busy;
>>>>       wxSound s;
>>>>
>>>>       if (name.empty())
>>>>       {
>>>>          s.Create(sizeof(beep), beep);
>>>>       }
>>>>       else
>>>>       {
>>>>          s.Create(name);
>>>>       }
>>>>
>>>>       if (s.IsOk())
>>>>       {
>>>>          s.Play(wxSOUND_SYNC);
>>>>       }
>>>>    }
>>>> }
>>>>
>>>> which is called from the ProgressDialog's destructor.
>>>>
>>>> So if you've got "beep on completion on longer activities" enabled in
>>>> preferences, and "whatever" has taken longer than 60s, you'll get the call
>>>> to wxFAIL_MSG().
>>>> (I can't see where BeepAfterDuration and BeepFileName can be set in
>>>> preferences.)
>>>>
>>>
>>> "Preferences > Interface"
>>> https://manual.audacityteam.org/man/interface_preferences.html
>>>
>>> I was not able to reproduce the problem, but I'd missed the "Beep on
>>> completion" element - I'll retest.
>>>
>>> Steve
>>>
>>>
>>>
>>>>
>>>> David.
>>>>
>>>> On Mon, 21 Jun 2021 at 03:31, Cliff <fly...@gm...> wrote:
>>>>
>>>>> Running MacOS Mojave. I have never seen this before. Ideas? It happens
>>>>> at the end of running the DeClicker plugin. Running on build  #760576 does
>>>>> not bring up the error. I don’t have any builds between the one that works
>>>>> and the one that does not. The assert does always give the same trace. I
>>>>> don’t use any other plugins so can’t say if it’s common to all plugins or
>>>>> just DeClicker. Built in Effects work normally.
>>>>>
>>>>> <PastedGraphic-2.png>
>>>>>
>>>>> Cliff
>>>>> _______________________________________________
>>>>> Audacity-quality mailing list
>>>>> Aud...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>>
>>>> _______________________________________________
>>>> Audacity-quality mailing list
>>>> Aud...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>>>
>>> _______________________________________________
>> Audacity-quality mailing list
>> Aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>>
> _______________________________________________
> Audacity-quality mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>
>
> _______________________________________________
> Audacity-quality mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-quality
>