Re: [Audacity-quality] bugs in 'Click Removal'

[Vaughan J. <va...@au...>]

On 12/16/2013 7:46 AM, Gale Andrews wrote:
>
> | From Steve the Fiddle <ste...@gm...>
> | Mon, 16 Dec 2013 10:43:31 +0000
> | Subject: [Audacity-quality] bugs in 'Click Removal'
>> On 16 December 2013 06:03, Vaughan Johnson <va...@au...> wrote:
>>> Hi. I'm eliding the context on this long discussion and answering only
>>> what I think is still open.
>>>
>>> A one-sample spike is not a realistic use case, but 1/3 fix of
>>> real-world problems is useful, somewhat.
>>>
>>> Thanks for updating manual/wiki, Gale. I've increased the responsiveness
>>> to the other cases where it does nothing, but still need to add an error
>>> alert.
>
> Thanks for your further work, Vaughan. That sounds useful when we
> have the alert, but AFAICT Click Removal isn't working at all in HEAD
> on Windows, even on artificial one sample spikes. Were you expecting
> that?

Ahem, just a one-character bug that I've just now fixed. Woke up this 
morning realizing I should have used "|=" instead of "&=". Amazing how 
much code review I do in my sleep!

Plus, I agglomerated the test for whether it did anything, to a higher 
level, so now it's not per track, it's for the entire selection.

Please test again. Thanks.

- V