[Audacity-devel] [patch] Nyquist language localization

[Ed M. <edg...@wa...>]

Patch attached
P3 bug changing language in Preferences , some elements don't change
The problems listed under this bug are due to multiple different issues. 

Bit more complicated but the cause is similar to other recent fixes to other
symptoms. A string was cached and re-used even after it was stale due to
language change. The cached string variable was also re-used in other code
so I split that up.

There is one potential problem I do not know how to test--see end of
message.


The problem I am trying to overcome is experienced by changing the language
in preferences.
Before applying the patch:
* Launch Audacity
* Open the Effects menu
	note the entry Nyquist Prompt... about half way down
* Open Preferences/Interface and change your language to French or a
language with which you are more comfortable
	if English is your only choice you will need to build the language
locals (as if you need directions) 
* Open the Effects menu
	note the entry Nyquist Prompt... about half way down--it has not
changed
* Close Audacity
* Launch Audacity
* Open the Effects menu
	note the entry Console Nyquist... (if you are using French)
* Open Preferences/Interface and change your language to English (or
initialize preferences after exit) 
* Close Audacity

Apply the patch.

* Launch Audacity
* Open the Effects menu
	note the entry Nyquist Prompt... about half way down
* Open Preferences/Interface and change your language to French or a
language with which you are more comfortable
* Open the Effects menu
	note the entry Console Nyquist... (if you are using French)--it
changed dynamically without re-start.

What I am trying to exercise is the code in Nyquist.cpp around line 250 but
I have no idea how to do so:

void EffectNyquist::Parse(wxString line)
{
[...]
   if (len >= 2 && tokens[0] == wxT("name")) {
#ifdef DEBUG
      if (!mUseFName) wxMessageBox(wxT("Should never see this tell\nEd
Musgrove\nNyquist.cpp language localization is broken at line 250."));
#endif
      mName = UnQuote(tokens[1]);
      return;
   } 



--Ed