Re: [Audacity-devel] GVerb -> Windows via Audacity

[Vaughan J. <vjo...@co...>]

Dominic Mazzoni wrote:

> Vaughan Johnson wrote:
>
>> I've made a version of GVerb that runs in Audacity on Windows via its 
>> LADSPA interface. I ran into a bunch of build issues that MSVC is 
>> picky about. For instance, fabsf() is defined for C++ but not for C, 
>> so I had to tell it to compile the .c files as .cpp. Anyway, it's 
>> "working" but I'm not sure it's handling the parameters correctly, so 
>> Windows users, please test:
>> "http://home.earthlink.net/~vaughanjohnson/audacity/amp/GVerb.zip"
>
>
> Excellent! 

I hope so. Had to attend to other things yesterday, but am catching up 
on email today.


>
>
>> I had to make a slight change to Audacity so it wouldn't crash 
>> putting together the dialog. That change is checked into the 1.2 
>> branch, and here's a fresh build with that change:
>> "http://home.earthlink.net/~vaughanjohnson/audacity/audacity-win_2003-10-12.zip"
>
>
> Too bad Audacity had a bug, too; maybe we should release 1.2.0-pre3
> after we have the VST enabler working too. 

It's that weird thing where wxWindows calls a text control's handler 
while the control is being constructed. Unfortunately, I had fixed it 
for what I thought was the general case, but it wasn't quite.

VST enabler is next on my list. A pre3 release sounds like a good idea.

>
>
>> It's just the executable, so drop it on top of a 1.2pre2 
>> installation, and put the GVerb.dll in its Plug-ins folder.
>>
>> Also, for grins, here's the amp plugin from the LADSPA SDK, the first 
>> LADSPA plug-in I did for Audacity on Windows: 
>> "http://home.earthlink.net/~vaughanjohnson/audacity/amp.zip".
>>
>> Juhana & Steve, let me know if you'd like the code. I started from 
>> "http://plugin.org.uk/src/gverb", but I also noticed 
>> "http://plugin.org.uk/src/gverb_1216.so.c". Sorry I'm not up on the 
>> naming conventions, is ".so" beta? Should I use that source instead 
>> of "http://plugin.org.uk/src/gverb/gverb_1210.c"?
>
>
> "so" stands for "shared object", which is the Unix equivalent of
> a DLL.  I think that the naming convention is that gverb*.so.c contains
> the plug-in "main" function and LADSPA code, while all of the other
> gverb files contain gverb-specific functions.  Simple plug-ins just
> throw everything in one file, but gverb also exists as a library
> somewhat independent of LADSPA. 

Thanks.

>
>
> But if you got it to work, you must have included some sensible
> collection of files. 

Yes, there was a corresponding "gverb_1210.c" in the directory with the 
other source files, and that's why I wondered about the one at the 
higher level.

>
>
> I ran into similar issues on the Mac, though I didn't realize that
> fabsf is defined for C++ - I thought it was part of C99.  Either
> way, functions like that need to be wrapped so that LADSPA plug-ins
> can be made more portable.

Yep, I wrapped all my changes in #ifdef WIN32.

-Vaughan