Thread: [Audacity-devel] change pitch effect crushes audacity
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Alexandre P. <tec...@la...> - 2004-04-29 16:13:43
|
Hi, I just have discovered a crash bug in Audacity's Change Pitch effect. 1. Get an audio track 2. Select something 3. Open Change Pitch dialog 4. Change pitch in any of 4 available ways 5. Apply changes or hit Preview 6. Audacity crashes with "Microsoft Visual C++ Runtime Error" dialog. It says also: Runtime Error! Program C:\Program Files\Audacity\audacity.exe abnormal program termination This may be related to recently installed Microsoft Visual C++ Toolkit 2003, but I can't be sure, of course. Alexandre |
From: Matt B. <mbr...@cs...> - 2004-04-29 16:22:44
|
Alexandre Prokoudine wrote: > I just have discovered a crash bug in Audacity's Change Pitch effect. I could not reproduce this on Windows XP or Linux. There is a known crashing bugs when entering percentages less than -100, or when using Change Pitch on a 96KHz track. Aside from that, I could not get it to crash with a variety of inputs and values. |
From: Vaughan J. <vjo...@co...> - 2004-04-29 20:28:32
|
Matt Brubeck wrote: >Alexandre Prokoudine wrote: > > > >>I just have discovered a crash bug in Audacity's Change Pitch effect. >> >> > >I could not reproduce this on Windows XP or Linux. > > > Me neither, on Win 2K Pro. -Vaughan |
From: Travis E. <tra...@ea...> - 2004-04-30 16:34:19
|
On 4/29/04 11:14 AM, Alexandre Prokoudine wrote: > Hi, > > I just have discovered a crash bug in Audacity's Change > Pitch effect. I'm having the same problem with Audacity 1.2.1. I get the Visual C++ Runtime Error when I try to use the Change Pitch effect, regardless of the percent setting (it even happens on 0% change). I'm running Windows 98SE. This problem doesn't appear to happen with Audacity 1.2.0. -- Travis Evans |
From: Matt B. <mbr...@cs...> - 2004-04-30 17:15:21
|
Travis Evans wrote: > > I just have discovered a crash bug in Audacity's Change Pitch > > effect. > > I'm having the same problem with Audacity 1.2.1. I get the Visual C++ > Runtime Error when I try to use the Change Pitch effect, regardless of > the percent setting (it even happens on 0% change). Okay, I actually can reproduce this in Audacity 1.2.1 on Windows XP (I may have been running the wrong version yesterday). It also happens on Change Tempo. The "Microsoft Visual C++ Runtime Error: abnormal program termination" dialog appears as soon as the OK button is pressed in either of these effects. I have no idea what might be causing this. :( |
From: Vaughan J. <vjo...@co...> - 2004-04-30 22:11:43
|
Matt Brubeck wrote: >Travis Evans wrote: > > > >>>I just have discovered a crash bug in Audacity's Change Pitch >>>effect. >>> >>> >>I'm having the same problem with Audacity 1.2.1. I get the Visual C++ >>Runtime Error when I try to use the Change Pitch effect, regardless of >>the percent setting (it even happens on 0% change). >> >> > >Okay, I actually can reproduce this in Audacity 1.2.1 on Windows XP >(I may have been running the wrong version yesterday). It also happens >on Change Tempo. > >The "Microsoft Visual C++ Runtime Error: abnormal program termination" >dialog appears as soon as the OK button is pressed in either of these >effects. > >I have no idea what might be causing this. :( > > > > I couldn't replicate it in 1.2.0, but can in 1.2.1. It's in Soundtouch, in AAFilter::calculateCoeffs(), a few stack frames above EffectChangePitch::Process()'s call to new SoundTouch(). In AAFilter::calculateCoeffs(), it happens consistently at the first st_assert() call. The length parameter is passed correctly, value 32, so the assertion should be okay, but it's an unhandled exception in KERNEL32.DLL, so probably can't find st_assert(). I've got to run, but I'll have more time to look at this later. Any ideas? Consider upgrading SoundTouch on the branch? -Vaughan |
From: Matt B. <mbr...@cs...> - 2004-04-30 22:22:16
|
Vaughan Johnson wrote: > In AAFilter::calculateCoeffs(), it happens consistently at the first > st_assert() call. The length parameter is passed correctly, value 32, > so the assertion should be okay, but it's an unhandled exception in > KERNEL32.DLL, so probably can't find st_assert(). I had to change the st_assert() macro to fix compilation errors on newer versions of gcc. The new version is probably causing problems with MSVC. Compilers don't seem to agree on how to treat the "throw" statement inside an expression. Newer versions of SoundTouch have eliminated st_assert(), and switched to using the standard C assert(). We should probably do the same for Audacity 1.2.1, by changing st_assert to this: #define st_assert(x) assert(x) |