Thread: [Audacity-devel] r12398 fails to build on Linux
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2013-06-28 12:55:16
|
export/ExportPCM.cpp: In member function 'char* ExportPCM::ConvertTo7bitASCII(const char*)': export/ExportPCM.cpp:594:4: error: 'BYTE' was not declared in this scope export/ExportPCM.cpp:594:9: error: expected ';' before 'c' export/ExportPCM.cpp:640:7: error: 'c' was not declared in this scope export/ExportPCM.cpp:642:13: error: 'c' was not declared in this scope make[1]: *** [export/ExportPCM.o] Error 1 make[1]: Leaving directory `/home/steve/sourcecode/audacity-clean/src' make: *** [audacity] Error 2 Steve |
From: Richard A. <ri...@au...> - 2013-06-28 19:27:46
|
On Fri, 28 Jun 2013 13:55:08 +0100 Steve the Fiddle <ste...@gm...> wrote: > export/ExportPCM.cpp: In member function 'char* > ExportPCM::ConvertTo7bitASCII(const char*)': > export/ExportPCM.cpp:594:4: error: 'BYTE' was not declared in this > scope export/ExportPCM.cpp:594:9: error: expected ';' before 'c' > export/ExportPCM.cpp:640:7: error: 'c' was not declared in this scope > export/ExportPCM.cpp:642:13: error: 'c' was not declared in this scope > make[1]: *** [export/ExportPCM.o] Error 1 > make[1]: Leaving directory `/home/steve/sourcecode/audacity-clean/src' > make: *** [audacity] Error 2 Yes, BYTE is not a valid C or wxWidgets type. Can it not be an ordinary char, or wxChar ? I'm also of the opinion that ConvertTo7bitASCII() should not be a member of the ExportPCM:: class! It would be a much better fit in the Internat:: class (src/Internat.h), which has all sorts of other conversions in it, including some charset ones. Although Vaughan says he didn't commit it, this looks like Joel Bouchat's patch for adding and reading id3 tags in WAV files which we received. Is it? Do the things you listed still need doing to it? Should we roll this commit back and apply it right, or patch from here to where we want to be? Richard |
From: Vaughan J. <va...@au...> - 2013-06-28 22:44:07
|
On 6/28/2013 12:27 PM, Richard Ash wrote: > On Fri, 28 Jun 2013 13:55:08 +0100 > Steve the Fiddle <ste...@gm...> wrote: > ... > Although Vaughan says he didn't commit it, this looks like Joel > Bouchat's patch for adding and reading id3 tags in WAV files which we > received. Is it? Yes, accidental OK in commit dialog via fat-fingered Enter button. :-( Decided not to clutter the thread with that news. >Do the things you listed still need doing to it? I've asked Joel to answer those questions. > Should we roll this commit back and apply it right, or patch from here > to where we want to be? I hope the latter. If Joel's answers seem right, probably no need to roll back either commit, assuming it will now build on Linux. - V |
From: Joel B. <bo...@ho...> - 2013-06-28 19:44:55
|
Hello Richard, Thank you for having experimented the patch on Unix... Maybe that I will install a Unix system at home in a near future, but up to now all that I have is a small Raspberry PI under Debian, but without compiler! BYTE can be replaced by the standard "unsigned char". (I DID know that BYTE is specific to Microsoft/Windows, but I missed this one ! I also think that "ConvertTo7bitASCII()" would be better located in a a more general class. It could be useful somewhere else in the future. I let it in ExportPCM:: to avoid modifying too many things... Best regards, Joël ---------------------------------------- > Date: Fri, 28 Jun 2013 20:27:34 +0100 > From: ri...@au... > To: aud...@li... > Subject: Re: [Audacity-devel] r12398 fails to build on Linux > > On Fri, 28 Jun 2013 13:55:08 +0100 > Steve the Fiddle <ste...@gm...> wrote: > >> export/ExportPCM.cpp: In member function 'char* >> ExportPCM::ConvertTo7bitASCII(const char*)': >> export/ExportPCM.cpp:594:4: error: 'BYTE' was not declared in this >> scope export/ExportPCM.cpp:594:9: error: expected ';' before 'c' >> export/ExportPCM.cpp:640:7: error: 'c' was not declared in this scope >> export/ExportPCM.cpp:642:13: error: 'c' was not declared in this scope >> make[1]: *** [export/ExportPCM.o] Error 1 >> make[1]: Leaving directory `/home/steve/sourcecode/audacity-clean/src' >> make: *** [audacity] Error 2 > > Yes, BYTE is not a valid C or wxWidgets type. Can it not be an ordinary > char, or wxChar ? > > I'm also of the opinion that ConvertTo7bitASCII() should not be a > member of the ExportPCM:: class! It would be a much better fit in the > Internat:: class (src/Internat.h), which has all sorts of other > conversions in it, including some charset ones. > > Although Vaughan says he didn't commit it, this looks like Joel > Bouchat's patch for adding and reading id3 tags in WAV files which we > received. Is it? Do the things you listed still need doing to it? > Should we roll this commit back and apply it right, or patch from here > to where we want to be? > > Richard > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Vaughan J. <va...@au...> - 2013-06-28 22:38:00
|
Okay, I made that change to unsigned char, revision 12403. But Joel, I made the previous commit by accident. As I wrote, I wasn't planning to commit it until you'd answered the questions I asked, because some of it looked non-cross-platform to me (but I missed BYTE). So, please go back to that email and respond to my questions. Thanks, V On 6/28/2013 12:44 PM, Joel Bouchat wrote: > Hello Richard, > > Thank you for having experimented the patch on Unix... > > Maybe that I will install a Unix system at home in a near future, but up to now all that I have is a small Raspberry PI under Debian, but without compiler! > > BYTE can be replaced by the standard "unsigned char". (I DID know that BYTE is specific to Microsoft/Windows, but I missed this one ! > > I also think that "ConvertTo7bitASCII()" would be better located in a a more general class. It could be useful somewhere else in the future. I let it in ExportPCM:: to avoid modifying too many things... > > Best regards, > > Joël > > ---------------------------------------- >> Date: Fri, 28 Jun 2013 20:27:34 +0100 >> From: ri...@au... >> To: aud...@li... >> Subject: Re: [Audacity-devel] r12398 fails to build on Linux >> >> On Fri, 28 Jun 2013 13:55:08 +0100 >> Steve the Fiddle <ste...@gm...> wrote: >> >>> export/ExportPCM.cpp: In member function 'char* >>> ExportPCM::ConvertTo7bitASCII(const char*)': >>> export/ExportPCM.cpp:594:4: error: 'BYTE' was not declared in this >>> scope export/ExportPCM.cpp:594:9: error: expected ';' before 'c' >>> export/ExportPCM.cpp:640:7: error: 'c' was not declared in this scope >>> export/ExportPCM.cpp:642:13: error: 'c' was not declared in this scope >>> make[1]: *** [export/ExportPCM.o] Error 1 >>> make[1]: Leaving directory `/home/steve/sourcecode/audacity-clean/src' >>> make: *** [audacity] Error 2 >> >> Yes, BYTE is not a valid C or wxWidgets type. Can it not be an ordinary >> char, or wxChar ? >> >> I'm also of the opinion that ConvertTo7bitASCII() should not be a >> member of the ExportPCM:: class! It would be a much better fit in the >> Internat:: class (src/Internat.h), which has all sorts of other >> conversions in it, including some charset ones. >> >> Although Vaughan says he didn't commit it, this looks like Joel >> Bouchat's patch for adding and reading id3 tags in WAV files which we >> received. Is it? Do the things you listed still need doing to it? >> Should we roll this commit back and apply it right, or patch from here >> to where we want to be? >> >> Richard >> >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by Windows: >> >> Build for Windows Store. >> >> http://p.sf.net/sfu/windows-dev2dev >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |