audacity-devel

[Audacity-devel] Audacity fails to build Debug on Mac

[Paul L. <pau...@bo...>]

I only do one debug build a week, early on a Sunday morning, this appears to be a problem introduced with 12077. Currently Audacity fails to build in debug due to errors in Envelope.cpp and TimeTrack.cpp, namely std::max() and std::min() are not defined.  Everything builds fine in release.

Obviously an easy fix but I'm curious if this is a Mac peculiarity or also occurs on Windows/Linux.

Regards,

Paul.

Re: [Audacity-devel] Audacity fails to build Debug on Mac

[Maarten B. <maa...@ho...>]

On 24/12/12 03:15, Paul Livesey wrote:
> I only do one debug build a week, early on a Sunday morning, this appears to be a problem introduced with 12077. Currently Audacity fails to build in debug due to errors in Envelope.cpp and TimeTrack.cpp, namely std::max() and std::min() are not defined.  Everything builds fine in release.
>
> Obviously an easy fix but I'm curious if this is a Mac peculiarity or also occurs on Windows/Linux.
>
> Regards,
>
> Paul.
Oops, that's my fault. They are defined in <algorithm> but I didn't 
explicitly include it (it was already included through some other 
header). I've corrected this in my next patch (attached).

Changes in this patch:
- More consistent range checking in Envelope, and the range can now be 
changed. EnvPoint is now a proper class with private member variables to 
ensure that all points are always within the allowed range of the envelope.
- Clean up some unneeded code from the previous patch.

It's a large patch but most of that is just replacing private member 
variables with Get/Set.

Maarten Baert

Re: [Audacity-devel] Audacity fails to build Debug on Mac

[Richard A. <ri...@au...>]

On Tue, 25 Dec 2012 15:28:42 +0100
Maarten Baert <maa...@ho...> wrote:

> On 24/12/12 03:15, Paul Livesey wrote:
> > I only do one debug build a week, early on a Sunday morning, this
> > appears to be a problem introduced with 12077. Currently Audacity
> > fails to build in debug due to errors in Envelope.cpp and
> > TimeTrack.cpp, namely std::max() and std::min() are not defined.
> > Everything builds fine in release.
> >
> > Obviously an easy fix but I'm curious if this is a Mac peculiarity
> > or also occurs on Windows/Linux.
It didn't seem to break for me on Linux, but I may not have had
quite the environment you have for Mac Debug set up, as I don't have a
debug copy of wxwidgets on this system.

> Oops, that's my fault. They are defined in <algorithm> but I didn't 
> explicitly include it (it was already included through some other 
> header). I've corrected this in my next patch (attached).
I've committed these two stand-alone changes into SVN, and will pay
some more attention to the rest of the patch shortly.

Richards

Re: [Audacity-devel] Audacity fails to build Debug on Mac

[Martyn S. <mar...@gm...>]

On 28/12/2012 14:17, Richard Ash wrote:
> On Tue, 25 Dec 2012 15:28:42 +0100
> Maarten Baert <maa...@ho...> wrote:
>
>> On 24/12/12 03:15, Paul Livesey wrote:
>>> I only do one debug build a week, early on a Sunday morning, this
>>> appears to be a problem introduced with 12077. Currently Audacity
>>> fails to build in debug due to errors in Envelope.cpp and
>>> TimeTrack.cpp, namely std::max() and std::min() are not defined.
>>> Everything builds fine in release.
>>>
>>> Obviously an easy fix but I'm curious if this is a Mac peculiarity
>>> or also occurs on Windows/Linux.
> It didn't seem to break for me on Linux, but I may not have had
> quite the environment you have for Mac Debug set up, as I don't have a
> debug copy of wxwidgets on this system.
>
>> Oops, that's my fault. They are defined in <algorithm> but I didn't
>> explicitly include it (it was already included through some other
>> header). I've corrected this in my next patch (attached).
> I've committed these two stand-alone changes into SVN, and will pay
> some more attention to the rest of the patch shortly.

Many thanks for your attention to this, Richard!

TTFN
Martyn

> Richards
>
> ------------------------------------------------------------------------------
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>