Thread: [Audacity-devel] Bug Fixing - much progress!
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Martyn S. <mar...@go...> - 2008-12-17 01:11:23
|
So how many is that gone now, in the last 4-5 days? http://audacityteam.org/wiki/index.php?title=Release_Checklist I have counted: 3 gone ('Creating a Label Track', 'When importing larger WAV files' and 'Generate effects don't fit in window') one fixed but additionals being discussed (Entering a negative three-digit value in "Change Speed") (should be cleared from the checklist). one to be verified on non-windows (Muting/soloing specific stereo tracks when exporting) another believed fixed (Code change restricting non-multi-channel devices). one partly fixed (Export Multiple using "other uncompressed files"), and a good start on it. Hopefully somebody will contribute. So that's 6 bugs (mostly) gone from the list + 2 more P2s that I have marked as not P2s really. + Gale has confirmed that he can make Release builds and installers (that work for me, at least). So it's nearly time for a release of our next Beta (on Windows at least)! Yeah! TTFN Martyn BTW will not be around tomorrow and Friday, Christmas parties and all! Maybe Thursday night?? |
From: Leland <le...@au...> - 2008-12-18 07:08:59
|
Martyn Shaw wrote: > one to be verified on non-windows (Muting/soloing specific stereo > tracks when exporting) > What should be checked? If I'm understanding it correctly, if you have 2 tracks and one is muted and you export, then ONLY the unmuted track gets exported? Some things I've tried...all with 2 selected mono tracks: 1) 1st track muted Only 2nd track is exported 2) 1st track muted and soloed Only 2nd track is exported 3) 1st track soloed 1st and 2nd track are mixed and exported as single track 4) 2nd track muted Only 1st track is exported 5) 2nd track muted and soloed Only 1st track is exported 6) 2nd track soloed 1st and 2nd track are mixed and exported as single track 7) Both tracks muted Both tracks exported as (sort of) empty files (maybe a msg instead?) 8) Both tracks soloed Both tracks mixed and exported as single track 9) Both tracks muted and soloed Both tracks exported as (sort of) empty files (maybe a msg instead?) > one partly fixed (Export Multiple using "other uncompressed files"), > and a good start on it. Hopefully somebody will contribute. > What's left? It seems to work okay here, but I'm sure I'm not seeing it all. Unless I'm not checking correctly, I can confirm that this doesn't happen here: "Reports on OS X with CVS of December 08 that the export button, though active, does not respond to being clicked (not due to having empty labels)" It clickies just fine. Leland |
From: Gale A. <ga...@au...> - 2008-12-18 20:04:42
|
| From Leland <le...@au...> | Thu, 18 Dec 2008 01:08:54 -0600 | Subject: [Audacity-devel] Bug Fixing - much progress! > > Martyn wrote: > > one to be verified on non-windows (Muting/soloing specific stereo > > tracks when exporting) > What should be checked? If I'm understanding it correctly, if you have > 2 tracks and one is muted and you export, then ONLY the unmuted track > gets exported? That's right. > Some things I've tried...all with 2 selected mono tracks.... There are a lot of permutations, and some issues seemed to require more than two tracks to trigger, and were highly unpredictable once you fiddled with them mute/solo buttons. Drove me mad. The issue as reported was with *stereo* tracks. I presume Martyn checked on stereo tracks but will try to take a quick look as well to be completely sure. Here on Windows XP ANSI Release, if I export a muted mono track (the only one on screen), its a null 44 byte file, and if I drag it back in, Audacity crashes. So perhaps we need more than a message. Either create a valid silent file after a prompt, or forbid it altogether (better?) > > one partly fixed (Export Multiple using "other uncompressed files"), > > and a good start on it. Hopefully somebody will contribute. > > > What's left? It seems to work okay here, but I'm sure I'm not seeing it > all. Compare with 1.2.5/6. We want to get a proper Big Endian AIFF when we choose "AIFF (Apple) signed 16 bit PCM", not an AIFF that is really a WAV; and we want to get (say) a 32-bit WAV by the single step of choosing it in "Other Uncompressed Files", not having to go to the confusing extra step of having to select the "WAV (Microsoft) 16 bit PCM" option afterwards to do it. See: http://n2.nabble.com/Release-Checklist%3A-PCM-export-multiple-td1653010.html > Unless I'm not checking correctly, I can confirm that this doesn't > happen here: > > "Reports on OS X with CVS of December 08 that the export button, though > active, does not respond to being clicked (not due to having empty labels)" > > It clickies just fine. OK, I can delete that, and the reports were pre-Richard's partial fix. There were two reports, but they were getting very confused with selecting AIFF in "Other uncompressed files" and appearing to find no AIFF files exported because in fact WAV's were being exported. Thanks Leland. Gale |
From: Martyn S. <mar...@go...> - 2008-12-18 23:17:21
|
Gale Andrews wrote: > | From Leland <le...@au...> > | Thu, 18 Dec 2008 01:08:54 -0600 > | Subject: [Audacity-devel] Bug Fixing - much progress! >>> Martyn wrote: >>> one to be verified on non-windows (Muting/soloing specific stereo >>> tracks when exporting) >> What should be checked? If I'm understanding it correctly, if you have >> 2 tracks and one is muted and you export, then ONLY the unmuted track >> gets exported? > > That's right. > >> Some things I've tried...all with 2 selected mono tracks.... > > There are a lot of permutations, and some issues seemed to require > more than two tracks to trigger, and were highly unpredictable > once you fiddled with them mute/solo buttons. Drove me mad. > > The issue as reported was with *stereo* tracks. I presume Martyn > checked on stereo tracks but will try to take a quick look as well to > be completely sure. The problem was with stereo (linked) tracks. When you clicked 'mute' only the first track of the pair had it's 'mute' flag set/cleared. Similarly with 'solo'. I tested with a stereo chirp, faded in, a stereo DTMF Tones, faded out, mono noise and so on. That way you can see from the waveforms that it is combining the correct tracks. > Here on Windows XP ANSI Release, if I export a muted mono track > (the only one on screen), its a null 44 byte file, and if I drag it back > in, Audacity crashes. So perhaps we need more than a message. > Either create a valid silent file after a prompt, or forbid it altogether > (better?) I tried this on Unicode-Debug and Release. I too get a 44 byte file but reading it in doesn't cause a crash on either version. I checked out the file against http://ccrma.stanford.edu/courses/422/projects/WaveFormat/ and the file looks byte for byte perfect to me. What differences do we have Gale? TTFN Martyn >>> one partly fixed (Export Multiple using "other uncompressed files"), >>> and a good start on it. Hopefully somebody will contribute. >>> >> What's left? It seems to work okay here, but I'm sure I'm not seeing it >> all. > > Compare with 1.2.5/6. We want to get a proper Big Endian AIFF when > we choose "AIFF (Apple) signed 16 bit PCM", not an AIFF that is really > a WAV; and we want to get (say) a 32-bit WAV by the single step of > choosing it in "Other Uncompressed Files", not having to go to the > confusing extra step of having to select the "WAV (Microsoft) 16 bit PCM" > option afterwards to do it. See: > http://n2.nabble.com/Release-Checklist%3A-PCM-export-multiple-td1653010.html > > >> Unless I'm not checking correctly, I can confirm that this doesn't >> happen here: >> >> "Reports on OS X with CVS of December 08 that the export button, though >> active, does not respond to being clicked (not due to having empty labels)" >> >> It clickies just fine. > > OK, I can delete that, and the reports were pre-Richard's partial fix. There > were two reports, but they were getting very confused with selecting AIFF > in "Other uncompressed files" and appearing to find no AIFF files exported > because in fact WAV's were being exported. > > Thanks Leland. > > > Gale > > ------------------------------------------------------------------------------ > SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. > The future of the web can't happen without you. Join us at MIX09 to help > pave the way to the Next Web now. Learn more and register at > http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Gale A. <ga...@au...> - 2008-12-19 20:08:44
|
| From Martyn Shaw <mar...@go...> | Thu, 18 Dec 2008 23:20:59 +0000 | Subject: [Audacity-devel] Bug Fixing - much progress! > Gale Andrews wrote: > > | From Leland <le...@au...> > > | Thu, 18 Dec 2008 01:08:54 -0600 > > | Subject: [Audacity-devel] Bug Fixing - much progress! > >>> Martyn wrote: > >>> one to be verified on non-windows (Muting/soloing specific stereo > >>> tracks when exporting) > >> What should be checked? If I'm understanding it correctly, if you have > >> 2 tracks and one is muted and you export, then ONLY the unmuted track > >> gets exported? > > > > That's right. > > > >> Some things I've tried...all with 2 selected mono tracks.... > > > > There are a lot of permutations, and some issues seemed to require > > more than two tracks to trigger, and were highly unpredictable > > once you fiddled with them mute/solo buttons. Drove me mad. > > > > The issue as reported was with *stereo* tracks. I presume Martyn > > checked on stereo tracks but will try to take a quick look as well to > > be completely sure. > > The problem was with stereo (linked) tracks. When you clicked 'mute' > only the first track of the pair had it's 'mute' flag set/cleared. > Similarly with 'solo'. I tested with a stereo chirp, faded in, a > stereo DTMF Tones, faded out, mono noise and so on. That way you can > see from the waveforms that it is combining the correct tracks. Thanks Martyn for that helpful extra info. I had to repurchase several CDs I had ripped then edited in Audacity, and sold the CDs, not knowing it had exported the files with a channel missing. So forgive my paranoia to check it's completely right :=) > > Here on Windows XP ANSI Release, if I export a muted mono track > > (the only one on screen), its a null 44 byte file, and if I drag it back > > in, Audacity crashes. So perhaps we need more than a message. > > Either create a valid silent file after a prompt, or forbid it altogether > > (better?) > > I tried this on Unicode-Debug and Release. I too get a 44 byte file > but reading it in doesn't cause a crash on either version. I checked > out the file against > http://ccrma.stanford.edu/courses/422/projects/WaveFormat/ and the > file looks byte for byte perfect to me. What differences do we have Gale? I tried Unicode Release from a few days ago. * Imported stereo 4 minute WAV 44100 Hz 16-bit at 32-bit quality. * Tracks > Stereo Track to Mono * Depress Mute * File > Export > WAV (Microsoft) 16 bit PCM, 44100 Hz rate * No progress dialogue (that you can see) * Exported file is 66 bytes: crash.wav on http://www.gaclrecords.org.uk/audacitytestfiles.html What happens now is as follows. If I drag the file in, nothing happens and I get a "doing" if I try to click on a menu or anywhere else. If I task switch away (ALT + TAB), Audacity disappears from Task Switcher window. It still has a tab in Taskbar which makes the program reappear but there is nothing you can do with it except force quit. If I File > Import the file, VS pops up offering to debug the crash: "unhandled win32 exception [3668]" Repeated with another similar file and get a 44 byte file on export this time (?) which also crashes. Now generate a 3 second mono DTMF tone, mute it, export as WAV as above, 44 byte file crashes Audacity on import. Gale |
From: Martyn S. <mar...@go...> - 2008-12-20 19:14:47
|
Gale Andrews wrote: > | From Martyn Shaw <mar...@go...> > | Thu, 18 Dec 2008 23:20:59 +0000 > | Subject: [Audacity-devel] Bug Fixing - much progress! >> Gale Andrews wrote: >>> | From Leland <le...@au...> >>> | Thu, 18 Dec 2008 01:08:54 -0600 >>> | Subject: [Audacity-devel] Bug Fixing - much progress! >>>>> Martyn wrote: >>>>> one to be verified on non-windows (Muting/soloing specific stereo >>>>> tracks when exporting) >>>> What should be checked? If I'm understanding it correctly, if you have >>>> 2 tracks and one is muted and you export, then ONLY the unmuted track >>>> gets exported? >>> That's right. >>> >>>> Some things I've tried...all with 2 selected mono tracks.... >>> There are a lot of permutations, and some issues seemed to require >>> more than two tracks to trigger, and were highly unpredictable >>> once you fiddled with them mute/solo buttons. Drove me mad. >>> >>> The issue as reported was with *stereo* tracks. I presume Martyn >>> checked on stereo tracks but will try to take a quick look as well to >>> be completely sure. >> The problem was with stereo (linked) tracks. When you clicked 'mute' >> only the first track of the pair had it's 'mute' flag set/cleared. >> Similarly with 'solo'. I tested with a stereo chirp, faded in, a >> stereo DTMF Tones, faded out, mono noise and so on. That way you can >> see from the waveforms that it is combining the correct tracks. > > Thanks Martyn for that helpful extra info. I had to repurchase several CDs I > had ripped then edited in Audacity, and sold the CDs, not knowing it had > exported the files with a channel missing. So forgive my paranoia to check > it's completely right :=) > > >>> Here on Windows XP ANSI Release, if I export a muted mono track >>> (the only one on screen), its a null 44 byte file, and if I drag it back >>> in, Audacity crashes. So perhaps we need more than a message. >>> Either create a valid silent file after a prompt, or forbid it altogether >>> (better?) >> I tried this on Unicode-Debug and Release. I too get a 44 byte file >> but reading it in doesn't cause a crash on either version. I checked >> out the file against >> http://ccrma.stanford.edu/courses/422/projects/WaveFormat/ and the >> file looks byte for byte perfect to me. What differences do we have Gale? > > I tried Unicode Release from a few days ago. > > * Imported stereo 4 minute WAV 44100 Hz 16-bit at 32-bit quality. > * Tracks > Stereo Track to Mono > * Depress Mute > * File > Export > WAV (Microsoft) 16 bit PCM, 44100 Hz rate > * No progress dialogue (that you can see) > * Exported file is 66 bytes: crash.wav on > http://www.gaclrecords.org.uk/audacitytestfiles.html > > What happens now is as follows. If I drag the file in, nothing happens > and I get a "doing" if I try to click on a menu or anywhere else. If I > task switch away (ALT + TAB), Audacity disappears from Task Switcher > window. It still has a tab in Taskbar which makes the program reappear > but there is nothing you can do with it except force quit. > > If I File > Import the file, VS pops up offering to debug the crash: > "unhandled win32 exception [3668]" > > Repeated with another similar file and get a 44 byte file on export this time > (?) which also crashes. > > Now generate a 3 second mono DTMF tone, mute it, export as WAV as above, > 44 byte file crashes Audacity on import. I tried all those things and no crashes here. Your 66 byte file looks fine too, just a bit of metadata different from the 44 byte ones. I guess it's another difference? Martyn > Gale > > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Gale A. <ga...@au...> - 2008-12-26 10:07:11
|
| From Martyn Shaw <mar...@go...> | Sat, 20 Dec 2008 19:18:27 +0000 | Subject: [Audacity-devel] Bug Fixing - much progress! > >>>>> Martyn wrote: > >>>>> one to be verified on non-windows (Muting/soloing specific stereo > >>>>> tracks when exporting) > >>>> What should be checked? If I'm understanding it correctly, if you have > >>>> 2 tracks and one is muted and you export, then ONLY the unmuted track > >>>> gets exported? > >>> That's right. > >>> > >>>> Some things I've tried...all with 2 selected mono tracks.... > >>> There are a lot of permutations, and some issues seemed to require > >>> more than two tracks to trigger, and were highly unpredictable > >>> once you fiddled with them mute/solo buttons. Drove me mad. > >>> > >>> The issue as reported was with *stereo* tracks. I presume Martyn > >>> checked on stereo tracks but will try to take a quick look as well to > >>> be completely sure. > >> The problem was with stereo (linked) tracks. When you clicked 'mute' > >> only the first track of the pair had it's 'mute' flag set/cleared. > >> Similarly with 'solo'. I tested with a stereo chirp, faded in, a > >> stereo DTMF Tones, faded out, mono noise and so on. That way you can > >> see from the waveforms that it is combining the correct tracks. I've removed this P2 after some more checking (including with Export Multiple and Custom Mix), and removed three other P2s which have been resolved or (old projects open incorrectly) aren't being pursued - thanks, Martyn. I do strongly agree with Leland though that we should have a warning if all the tracks being exported are muted. For someone coming from 1.2, unaware that mute now prevents export, it would be quite easy to have all the tracks soloed and muted and believe you were going to get all the tracks in the mix. We already have this check for Export Selection - if all the selected tracks are muted, a warning pops up "Unable to export" with a rather confusing message "No tracks are selected! Use Ctrl-A (Select All) Choose Export...to export all tracks". As far as I can see this message does not appear under any other circumstances. So (to me) I think this should be a P2 or P3 to prevent File > Export... proceeding when all tracks are muted, and clarify/adjust the wording of the "Unable to export" message that currently pops up with Export Selection (so you get a more useful suggestion if you actually only want to export a selection). I'd vote for P2, on the grounds user may not realise until it's too late that the exported file is useless. > >>> Here on Windows XP ANSI Release, if I export a muted mono track > >>> (the only one on screen), its a null 44 byte file, and if I drag it back > >>> in, Audacity crashes. So perhaps we need more than a message. > >>> Either create a valid silent file after a prompt, or forbid it altogether > >>> (better?) > >> I tried this on Unicode-Debug and Release. I too get a 44 byte file > >> but reading it in doesn't cause a crash on either version. I checked > >> out the file against > >> http://ccrma.stanford.edu/courses/422/projects/WaveFormat/ and the > >> file looks byte for byte perfect to me. What differences do we have Gale? > >> I tried all those things and no crashes here. Your 66 byte file looks > >> fine too, just a bit of metadata different from the 44 byte ones. > >> I guess it's another difference? The null exported files do not crash Audacity as soon as I used some other audio to export with. That audio might have been recovered after a force quit, anyway not an issue now. Will try and digest/comment on your input about " P2 Ensure all Edit menu items consistently enabled.." soon. Thanks Gale |
From: Martyn S. <mar...@go...> - 2008-12-27 22:00:43
|
Gale Andrews wrote: ... > I do strongly agree with Leland though that we should have a warning > if all the tracks being exported are muted. For someone coming from > 1.2, unaware that mute now prevents export, it would be quite easy > to have all the tracks soloed and muted and believe you were going > to get all the tracks in the mix. > > We already have this check for Export Selection - if all the selected > tracks are muted, a warning pops up "Unable to export" with a rather > confusing message "No tracks are selected! Use Ctrl-A (Select All) > Choose Export...to export all tracks". As far as I can see this message > does not appear under any other circumstances. So (to me) I think > this should be a P2 or P3 to prevent File > Export... proceeding when > all tracks are muted, and clarify/adjust the wording of the "Unable to > export" message that currently pops up with Export Selection (so you > get a more useful suggestion if you actually only want to export a > selection). I'd vote for P2, on the grounds user may not realise until > it's too late that the exported file is useless. Agreed. I've put a fix into CVS. What do you think? Martyn |
From: Gale A. <ga...@au...> - 2009-01-01 08:51:23
|
| From Martyn Shaw <mar...@go...> | Sat, 27 Dec 2008 21:40:25 +0000 | Subject: [Audacity-devel] Bug Fixing - much progress! > Gale Andrews wrote: > ... > > I do strongly agree with Leland though that we should have a warning > > if all the tracks being exported are muted. For someone coming from > > 1.2, unaware that mute now prevents export, it would be quite easy > > to have all the tracks soloed and muted and believe you were going > > to get all the tracks in the mix. > > > > We already have this check for Export Selection - if all the selected > > tracks are muted, a warning pops up "Unable to export" with a rather > > confusing message "No tracks are selected! Use Ctrl-A (Select All) > > Choose Export...to export all tracks". As far as I can see this message > > does not appear under any other circumstances. So (to me) I think > > this should be a P2 or P3 to prevent File > Export... proceeding when > > all tracks are muted, and clarify/adjust the wording of the "Unable to > > export" message that currently pops up with Export Selection (so you > > get a more useful suggestion if you actually only want to export a > > selection). I'd vote for P2, on the grounds user may not realise until > > it's too late that the exported file is useless. > > Agreed. I've put a fix into CVS. What do you think? Thanks, Martyn. I'm not quite sure how well "active" in the error message might be understood. The audio could be soloed (so blue and audible), and could be selected as well. In fact the message for being unable to export a selection does not mention muting at all. Could this message occur in some situation where muting is not relevant? If not, might I suggest one of: * "All the audio is muted." and "All the selected audio is muted." (drop "the" and keep your exclamation mark if preferred) * "Please unmute the audio you want to export." (same message for Export and Export Selection) I think I slightly prefer the first bullet point. Not too worried anyway, if we can can be more specific than "active". Gale |
From: Martyn S. <mar...@go...> - 2009-01-01 22:17:44
|
Gale Andrews wrote: ... > * "All the audio is muted." and "All the selected audio is muted." ... I agree that these are better messages, please commit as I have a bunch of other experimental stuff in Export.cpp at the moment, and I'm off on holiday very soon. Thanks Martyn |
From: Gale A. <ga...@au...> - 2009-01-02 05:17:05
|
| From Martyn Shaw <mar...@go...> | Thu, 01 Jan 2009 22:21:44 +0000 | Subject: [Audacity-devel] Bug Fixing - much progress! > > Gale Andrews wrote: > ... > > * "All the audio is muted." and "All the selected audio is muted." > ... > > I agree that these are better messages, please commit as I have a > bunch of other experimental stuff in Export.cpp at the moment, and I'm > off on holiday very soon. Done. Gale |