Thread: [Audacity-devel] some translation issues fixings
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
Menu
▾
▴
audacity-devel
|
From: Andreas M. <And...@gm...> - 2007-12-01 18:34:17
|
Hi,
I'm trying to fix the static wxString issues now.
One I already have:
In Leveller.cpp:
static wxString numPasses[NUM_PASSES_CHOICES];
static double gFrameSum; // odd ... having this as member var crashed on
exit
bool EffectLeveller::Init()
{
numPasses[0] = _("None-Skip");
numPasses[1] = _("Light");
numPasses[2] = _("Moderate");
numPasses[3] = _("Heavy");
numPasses[4] = _("Heavier");
numPasses[5] = _("Heaviest");
May I check those easy ones in?
More to come...
Thanks,
Andreas
|
|
From: Andreas M. <And...@gm...> - 2007-12-01 18:42:06
|
Andreas Micheler wrote:
> Hi,
>
> I'm trying to fix the static wxString issues now.
>
> One I already have:
> In Leveller.cpp:
>
...
> More to come...
I have found only one more:
In Equalization.cpp:
static wxString interpChoiceStrings[NUM_INTERP_CHOICES];
EffectEqualization::EffectEqualization()
{
...
interpChoiceStrings[0] = _("B-spline");
interpChoiceStrings[1] = _("Cosine");
interpChoiceStrings[2] = _("Cubic");
}
So this Essential seems cleared to me. Is it really?
Thanks,
Andreas
|
|
From: Andreas M. <And...@gm...> - 2007-12-01 18:49:48
|
Andreas Micheler wrote: > So this Essential seems cleared to me. Is it really? > No, sorry! I saw lots of more now in ExportMP3.cpp, as described in the Wiki. Soon more... Andreas |
|
From: Andreas M. <And...@gm...> - 2007-12-01 19:39:34
|
Andreas Micheler wrote:
> Hi,
>
> I'm trying to fix the static wxString issues now.
>
In ExportMP3.cpp:
#define FIX_STATIC_INITS
#ifdef FIX_STATIC_INITS
static CHOICES fixRates[] =
{
/* i18n-hint: kbps is the bitrate of the MP3 file, kilobits per second*/
{wxT(""), 8},
{wxT(""), 16},
{wxT(""), 24},
{wxT(""), 32},
{wxT(""), 40},
{wxT(""), 48},
{wxT(""), 56},
{wxT(""), 64},
{wxT(""), 80},
{wxT(""), 96},
{wxT(""), 112},
{wxT(""), 128},
{wxT(""), 144},
{wxT(""), 160},
{wxT(""), 192},
{wxT(""), 224},
{wxT(""), 256},
{wxT(""), 320}
};
static CHOICES varRates[] =
{
{wxT(""), QUALITY_0},
{wxT(""), QUALITY_1},
{wxT(""), QUALITY_2},
{wxT(""), QUALITY_3},
{wxT(""), QUALITY_4},
{wxT(""), QUALITY_5},
{wxT(""), QUALITY_6},
{wxT(""), QUALITY_7},
{wxT(""), QUALITY_8},
{wxT(""), QUALITY_9},
};
static CHOICES varModes[] =
{
{wxT(""), ROUTINE_FAST },
{wxT(""), ROUTINE_STANDARD}
};
static CHOICES setRates[] =
{
{wxT(""), PRESET_INSANE },
{wxT(""), PRESET_EXTREME },
{wxT(""), PRESET_STANDARD},
{wxT(""), PRESET_MEDIUM },
};
static CHOICES sampRates[] =
{
{wxT(""), 8000 },
{wxT(""), 11025 },
{wxT(""), 12000 },
{wxT(""), 16000 },
{wxT(""), 22050 },
{wxT(""), 24000 },
{wxT(""), 32000 },
{wxT(""), 44100 },
{wxT(""), 48000 },
};
#else //!FIX_STATIC_INITS
static CHOICES fixRates[] =
{
/* i18n-hint: kbps is the bitrate of the MP3 file, kilobits per second*/
{ wxString(wxT("8 "))+_("kbps"), 8 },
{ wxString(wxT("16 "))+_("kbps"), 16 },
{ wxString(wxT("24 "))+_("kbps"), 24 },
{ wxString(wxT("32 "))+_("kbps"), 32 },
{ wxString(wxT("40 "))+_("kbps"), 40 },
{ wxString(wxT("48 "))+_("kbps"), 48 },
{ wxString(wxT("56 "))+_("kbps"), 56 },
{ wxString(wxT("64 "))+_("kbps"), 64 },
{ wxString(wxT("80 "))+_("kbps"), 80 },
{ wxString(wxT("96 "))+_("kbps"), 96 },
{ wxString(wxT("112 "))+_("kbps"), 112 },
{ wxString(wxT("128 "))+_("kbps"), 128 },
{ wxString(wxT("144 "))+_("kbps"), 144 },
{ wxString(wxT("160 "))+_("kbps"), 160 },
{ wxString(wxT("192 "))+_("kbps"), 192 },
{ wxString(wxT("224 "))+_("kbps"), 224 },
{ wxString(wxT("256 "))+_("kbps"), 256 },
{ wxString(wxT("320 "))+_("kbps"), 320 }
};
static CHOICES varRates[] =
{
{ _("0, 220-260 kbps (Best Quality)"), QUALITY_0 },
{ _("1, 200-250 kbps"), QUALITY_1 },
{ _("2, 170-210 kbps"), QUALITY_2 },
{ _("3, 155-195 kbps"), QUALITY_3 },
{ _("4, 145-185 kbps"), QUALITY_4 },
{ _("5, 110-150 kbps"), QUALITY_5 },
{ _("6, 95-135 kbps"), QUALITY_6 },
{ _("7, 80-120 kbps"), QUALITY_7 },
{ _("8, 65-105 kbps"), QUALITY_8 },
{ _("9, 45-85 kbps (Smaller files)"), QUALITY_9 }
};
static CHOICES varModes[] =
{
{ _("Fast"), ROUTINE_FAST },
{ _("Standard"), ROUTINE_STANDARD }
};
static CHOICES setRates[] =
{
{ _("Insane, 320 kbps"), PRESET_INSANE },
{ _("Extreme, 220-260 kbps"), PRESET_EXTREME },
{ _("Standard, 170-210 kbps"), PRESET_STANDARD },
{ _("Medium, 145-185 kbps"), PRESET_MEDIUM },
};
static CHOICES sampRates[] =
{
{ wxT("8000"), 8000 },
{ wxT("11025"), 11025 },
{ wxT("12000"), 12000 },
{ wxT("16000"), 16000 },
{ wxT("22050"), 22050 },
{ wxT("24000"), 24000 },
{ wxT("32000"), 32000 },
{ wxT("44100"), 44100 },
{ wxT("48000"), 48000 },
};
#endif //FIX_STATIC_INITS
....
ExportMP3Options::ExportMP3Options(wxWindow *parent)
: wxDialog(NULL, wxID_ANY,
wxString(_("Specify MP3 Options")),
wxDefaultPosition, wxDefaultSize,
wxDEFAULT_DIALOG_STYLE | wxSTAY_ON_TOP)
{
#ifdef FIX_STATIC_INITS
for (int i=0; i < WXSIZEOF(fixRates); i++)
{
fixRates[i].name = wxT("");
fixRates[i].name << fixRates[i].label << wxT(" ") << _("kbps");
}
for (int i=0; i < WXSIZEOF(varRates); i++)
{
varRates[i].name = wxT("");
varRates[i].name << i << wxT(", ");
}
varRates[0].name << wxT("220-260");
varRates[1].name << wxT("200-250");
varRates[2].name << wxT("170-210");
varRates[3].name << wxT("155-195");
varRates[4].name << wxT("145-185");
varRates[5].name << wxT("110-150");
varRates[6].name << wxT("95-135");
varRates[7].name << wxT("80-120");
varRates[8].name << wxT("65-105");
varRates[9].name << wxT("45-85");
for (int i=0; i < WXSIZEOF(varRates); i++)
varRates[i].name << wxT(" ") << _("kbps");
varRates[0].name << wxT(" ") << _("(Best Quality)");
varRates[9].name << wxT(" ") << _("(Smaller files)");
varModes[0].name = _("Fast");
varModes[1].name = _("Standard");
for (int i=0; i < WXSIZEOF(setRates); i++)
setRates[i].name = wxT("");
setRates[0].name << _("Insane" ) << wxT(", ") << 320;
setRates[1].name << _("Extreme" ) << wxT(", ") << 220 << wxT("-") << 260;
setRates[2].name << _("Standard") << wxT(", ") << 170 << wxT("-") << 210;
setRates[3].name << _("Medium" ) << wxT(", ") << 145 << wxT("-") << 185;
for (int i=0; i < WXSIZEOF(setRates); i++)
setRates[i].name << wxT(" ") << _("kbps");
for (int i=0; i < WXSIZEOF(sampRates); i++)
{
sampRates[i].name = wxT("");
sampRates[i].name << sampRates[i].label;
}
#endif //FIX_STATIC_INITS
ShuttleGui S(this, eIsCreatingFromPrefs);
PopulateOrExchange(S);
}
Can I check this in?
Cheers,
Andreas
|
|
From: Richard A. <ri...@au...> - 2007-12-01 21:35:23
|
On Sat, 2007-12-01 at 20:39 +0100, Andreas Micheler wrote: > Andreas Micheler wrote: > > Hi, > > > > I'm trying to fix the static wxString issues now. > > > In ExportMP3.cpp: > Can I check this in? yes, minus the #ifdef FIX_STATIC_INITS bits, because we want this in 1.3.5 Richard |
|
From: Andreas M. <And...@gm...> - 2007-12-01 20:06:36
|
Andreas Micheler wrote:
> Hi,
>
> I'm trying to fix the static wxString issues now.
>
Tags.cpp, line 629:
#define FIX_STATIC_INITS
#ifdef FIX_STATIC_INITS
static wxString names[] =
{
LABEL_ARTIST,
LABEL_TITLE,
LABEL_ALBUM,
LABEL_TRACK,
LABEL_YEAR,
LABEL_GENRE,
LABEL_COMMENTS
};
static struct
{
wxString label;
wxString name;
}
labelmap[] =
{
{ LABEL_ARTIST, TAG_ARTIST },
{ LABEL_TITLE, TAG_TITLE },
{ LABEL_ALBUM, TAG_ALBUM },
{ LABEL_TRACK, TAG_TRACK },
{ LABEL_YEAR, TAG_YEAR },
{ LABEL_GENRE, TAG_GENRE },
{ LABEL_COMMENTS, TAG_COMMENTS }
};
#else //!FIX_STATIC_INITS
static const wxChar *names[] =
{
LABEL_ARTIST,
LABEL_TITLE,
LABEL_ALBUM,
LABEL_TRACK,
LABEL_YEAR,
LABEL_GENRE,
LABEL_COMMENTS
};
static const struct
{
const wxChar *label;
const wxChar *name;
}
labelmap[] =
{
{ LABEL_ARTIST, TAG_ARTIST },
{ LABEL_TITLE, TAG_TITLE },
{ LABEL_ALBUM, TAG_ALBUM },
{ LABEL_TRACK, TAG_TRACK },
{ LABEL_YEAR, TAG_YEAR },
{ LABEL_GENRE, TAG_GENRE },
{ LABEL_COMMENTS, TAG_COMMENTS }
};
#endif //FIX_STATIC_INITS
...
TagsEditor::TagsEditor(wxWindow * parent,
wxString title,
Tags * tags,
bool editTitle,
bool editTrack)
: wxDialog(parent, wxID_ANY, title, wxDefaultPosition, wxDefaultSize,
wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER),
mTags(tags),
mEditTitle(editTitle),
mEditTrack(editTrack)
{
#ifdef FIX_STATIC_INITS
names[0] = LABEL_ARTIST;
names[1] = LABEL_TITLE;
names[2] = LABEL_ALBUM;
names[3] = LABEL_TRACK;
names[4] = LABEL_YEAR;
names[5] = LABEL_GENRE;
names[6] = LABEL_COMMENTS;
labelmap[0].label = LABEL_ARTIST;
labelmap[1].label = LABEL_TITLE;
labelmap[2].label = LABEL_ALBUM;
labelmap[3].label = LABEL_TRACK;
labelmap[4].label = LABEL_YEAR;
labelmap[5].label = LABEL_GENRE;
labelmap[6].label = LABEL_COMMENTS;
labelmap[0].name = TAG_ARTIST;
labelmap[1].name = TAG_TITLE;
labelmap[2].name = TAG_ALBUM;
labelmap[3].name = TAG_TRACK;
labelmap[4].name = TAG_YEAR;
labelmap[5].name = TAG_GENRE;
labelmap[6].name = TAG_COMMENTS;
#endif //FIX_STATIC_INITS
...
Cheers,
Andreas
|
|
From: Andreas M. <And...@gm...> - 2007-12-01 20:38:21
|
Andreas Micheler wrote:
> Hi,
>
> I'm trying to fix the static wxString issues now.
>
TimeTextCtrl.cpp, line 297ff:
TimeTextCtrl::TimeTextCtrl(wxWindow *parent,
...
{
#define FIX_STATIC_INITS
#ifdef FIX_STATIC_INITS
BuiltinFormatStrings[0].name = _("seconds");
BuiltinFormatStrings[0].formatStr = _("01000,01000 seconds");
BuiltinFormatStrings[1].name = _("hh:mm:ss");
BuiltinFormatStrings[1].formatStr = _("0100 h 060 m 060 s");
BuiltinFormatStrings[2].name = _("dd:hh:mm:ss");
BuiltinFormatStrings[2].formatStr = _("0100 days 024 h 060 m 060 s");
BuiltinFormatStrings[3].name = _("hh:mm:ss + milliseconds");
BuiltinFormatStrings[3].formatStr = _("0100 h 060 m 060.01000 s");
BuiltinFormatStrings[4].name = _("hh:mm:ss + samples");
BuiltinFormatStrings[4].formatStr = _("0100 h 060 m 060 s+.# samples");
BuiltinFormatStrings[5].name = _("samples");
BuiltinFormatStrings[5].formatStr = _("01000,01000,01000 samples|#");
BuiltinFormatStrings[6].name = _("hh:mm:ss + film frames (24 fps)");
BuiltinFormatStrings[6].formatStr = _("0100 h 060 m 060 s+.24 frames");
BuiltinFormatStrings[7].name = _("film frames (24 fps)");
BuiltinFormatStrings[7].formatStr = _("01000,01000 frames|24");
BuiltinFormatStrings[8].name = _("hh:mm:ss + NTSC drop frames");
BuiltinFormatStrings[8].formatStr = _("0100 h 060 m 060 s+.30 frames|N");
BuiltinFormatStrings[9].name = _("hh:mm:ss + NTSC non-drop frames");
BuiltinFormatStrings[9].formatStr = _("0100 h 060 m 060 s+.030
frames| .999000999");
BuiltinFormatStrings[10].name = _("NTSC frames");
BuiltinFormatStrings[10].formatStr = _("01000,01000 frames|29.97002997");
BuiltinFormatStrings[11].name = _("hh:mm:ss + PAL frames (25 fps)");
BuiltinFormatStrings[11].formatStr = _("0100 h 060 m 060 s+.25 frames");
BuiltinFormatStrings[12].name = _("PAL frames (25 fps)");
BuiltinFormatStrings[12].formatStr = _("01000,01000 frames|25");
BuiltinFormatStrings[13].name = _("hh:mm:ss + CDDA frames (75 fps)");
BuiltinFormatStrings[13].formatStr = _("0100 h 060 m 060 s+.75 frames");
BuiltinFormatStrings[14].name = _("CDDA frames (75 fps)");
BuiltinFormatStrings[14].formatStr = _("01000,01000 frames|75");
#endif //FIX_STATIC_INITS
Cheers,
Andreas
|
|
From: Andreas M. <And...@gm...> - 2007-12-01 20:43:29
|
Andreas Micheler wrote:
> Andreas Micheler wrote:
>
>> Hi,
>>
>> I'm trying to fix the static wxString issues now.
>>
I just saw some memory leaks,
so I'd add to TimeTextCtrl.cpp, line 191:
#define FIX_STATIC_INITS
#ifdef FIX_STATIC_INITS
struct BuiltinFormatString {
wxString name;
wxString formatStr;
};
#else //!FIX_STATIC_INITS
struct BuiltinFormatString {
const wxChar *name;
const wxChar *formatStr;
};
#endif //FIX_STATIC_INITS
Cheers,
Andreas
|
|
From: Richard A. <ri...@au...> - 2007-12-01 21:33:24
|
On Sat, 2007-12-01 at 21:38 +0100, Andreas Micheler wrote:
> TimeTextCtrl.cpp, line 297ff:
No point in the #ifdef - we want this in 1.3.5. This will need some
i18n-hints putting in, because translating these is non-trivial, and
getting them wrong will break the functionality and display the wrong
time code.
In general the rule is to not touch the numbers and # signs (because
they drive the timecode formatting), but the text strings and single
characters need to be translated because they appear on screen.
If you want to commit your change to make them translateable, then I
will try and add the comments (as I put most of the formats in to start
with).
Richard
> TimeTextCtrl::TimeTextCtrl(wxWindow *parent,
> ...
> {
> #define FIX_STATIC_INITS
>
> #ifdef FIX_STATIC_INITS
> BuiltinFormatStrings[0].name = _("seconds");
> BuiltinFormatStrings[0].formatStr = _("01000,01000 seconds");
> BuiltinFormatStrings[1].name = _("hh:mm:ss");
> BuiltinFormatStrings[1].formatStr = _("0100 h 060 m 060 s");
> BuiltinFormatStrings[2].name = _("dd:hh:mm:ss");
> BuiltinFormatStrings[2].formatStr = _("0100 days 024 h 060 m 060 s");
> BuiltinFormatStrings[3].name = _("hh:mm:ss + milliseconds");
> BuiltinFormatStrings[3].formatStr = _("0100 h 060 m 060.01000 s");
> BuiltinFormatStrings[4].name = _("hh:mm:ss + samples");
> BuiltinFormatStrings[4].formatStr = _("0100 h 060 m 060 s+.# samples");
> BuiltinFormatStrings[5].name = _("samples");
> BuiltinFormatStrings[5].formatStr = _("01000,01000,01000 samples|#");
> BuiltinFormatStrings[6].name = _("hh:mm:ss + film frames (24 fps)");
> BuiltinFormatStrings[6].formatStr = _("0100 h 060 m 060 s+.24 frames");
> BuiltinFormatStrings[7].name = _("film frames (24 fps)");
> BuiltinFormatStrings[7].formatStr = _("01000,01000 frames|24");
> BuiltinFormatStrings[8].name = _("hh:mm:ss + NTSC drop frames");
> BuiltinFormatStrings[8].formatStr = _("0100 h 060 m 060 s+.30 frames|N");
> BuiltinFormatStrings[9].name = _("hh:mm:ss + NTSC non-drop frames");
> BuiltinFormatStrings[9].formatStr = _("0100 h 060 m 060 s+.030
> frames| .999000999");
> BuiltinFormatStrings[10].name = _("NTSC frames");
> BuiltinFormatStrings[10].formatStr = _("01000,01000 frames|29.97002997");
> BuiltinFormatStrings[11].name = _("hh:mm:ss + PAL frames (25 fps)");
> BuiltinFormatStrings[11].formatStr = _("0100 h 060 m 060 s+.25 frames");
> BuiltinFormatStrings[12].name = _("PAL frames (25 fps)");
> BuiltinFormatStrings[12].formatStr = _("01000,01000 frames|25");
> BuiltinFormatStrings[13].name = _("hh:mm:ss + CDDA frames (75 fps)");
> BuiltinFormatStrings[13].formatStr = _("0100 h 060 m 060 s+.75 frames");
> BuiltinFormatStrings[14].name = _("CDDA frames (75 fps)");
> BuiltinFormatStrings[14].formatStr = _("01000,01000 frames|75");
> #endif //FIX_STATIC_INITS
>
> Cheers,
> Andreas
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell. From the desktop to the data center, Linux is going
> mainstream. Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> Audacity-devel mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
|
|
From: Andreas M. <And...@gm...> - 2007-12-02 17:14:46
|
Hallo Richard,
I just tried to be as careful as I could, that's why I put the #ifdef's in.
Now I removed the #ifdef's and commited the translation issues changes,
except TimeTextCtrl.cpp.
Instead I post the code of TimeTextCtrl.cpp here,
because I have split the strings now
and do not pass numbers and # signs to _() anymore.
I just want to know if that's okay so before I commit it:
BuiltinFormatString *fs=BuiltinFormatStrings;
fs[0].name = _("seconds");
fs[0].formatStr = wxString(wxT("01000"))+_(",")+wxT("01000
")+_("seconds");
fs[1].name = _("hh:mm:ss");
fs[1].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s");
fs[2].name = _("dd:hh:mm:ss");
fs[2].formatStr = wxString(wxT("0100 "))+_("days")+wxT(" 024
")+_("h")+wxT(" 060 ")+_("m")+wxT(" 060 ")+_("s");
fs[3].name = _("hh:mm:ss + milliseconds");
fs[3].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060.01000 ")+_("s");
fs[4].name = _("hh:mm:ss + samples");
fs[4].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s")+wxT("+.# ")+_("samples");
fs[5].name = _("samples");
fs[5].formatStr =
wxString(wxT("01000"))+_(",")+wxT("01000")+_(",")+wxT("01000
")+_("samples")+wxT("|#");
fs[6].name = _("hh:mm:ss + film frames (24 fps)");
fs[6].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s")+wxT("+.24 ")+_("frames");
fs[7].name = _("film frames (24 fps)");
fs[7].formatStr = wxString(wxT("01000"))+_(",")+wxT("01000
")+_("frames")+wxT("|24");
fs[8].name = _("hh:mm:ss + NTSC drop frames");
fs[8].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s")+wxT("+.30 ")+_("frames")+wxT("|N");
fs[9].name = _("hh:mm:ss + NTSC non-drop frames");
fs[9].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s")+wxT("+.030 ")+_("frames")+wxT("| .999000999");
fs[10].name = _("NTSC frames");
fs[10].formatStr = wxString(wxT("01000"))+_(",")+wxT("01000
")+_("frames")+wxT("|29.97002997");
fs[11].name = _("hh:mm:ss + PAL frames (25 fps)");
fs[11].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s")+wxT("+.25 ")+_("frames");
fs[12].name = _("PAL frames (25 fps)");
fs[12].formatStr = wxString(wxT("01000"))+_(",")+wxT("01000
")+_("frames")+wxT("|25");
fs[13].name = _("hh:mm:ss + CDDA frames (75 fps)");
fs[13].formatStr = wxString(wxT("0100 "))+_("h")+wxT(" 060
")+_("m")+wxT(" 060 ")+_("s")+wxT("+.75 ")+_("frames");
fs[14].name = _("CDDA frames (75 fps)");
fs[14].formatStr = wxString(wxT("01000"))+_(",")+wxT("01000
")+_("frames")+wxT("|75");
What about comma and dot? Should they be translated at all?
In German comma separates the 1s from the 1/10,
but dot normally separates 100s from 1000s and 100000s from 1000000s.
Cheers,
Andreas
|
|
From: Richard A. <ri...@au...> - 2007-12-01 21:28:32
|
On Sat, 2007-12-01 at 19:34 +0100, Andreas Micheler wrote: > I'm trying to fix the static wxString issues now. > May I check those easy ones in? Yes. If you're pasting code into emails to illustrate what you want to change, then I at least would find unified diffs a lot easier to work with, because I don't know what most of the code looked like before. Richard |
|
From: Andreas M. <And...@gm...> - 2007-12-02 17:46:38
|
Hi all,
I'm a bit confused about this "Essential":
* With foreign languages (at least French and German) selected, MP3
metadata tags for "Artist Name", "Track Title", "Album Title" and
"Track Number" are not filled, so not seen by media applications.
Instead, duplicated custom tags with these identifiers are
created. MM suggests some strings are marked for translation but
used as keys.
I just tried to Export an MP3 (with user interface in German),
edited the tags, and looked at the file info in WinAmp,
where all the info appeared.
Can anyone give me a hint, how I shall test this one?
(I cannot reproduce it)
Thanks,
Andreas
|
|
From: Richard A. <ri...@au...> - 2007-12-02 19:26:30
|
On Sun, 2007-12-02 at 18:46 +0100, Andreas Micheler wrote: > I'm a bit confused about this "Essential": > > * With foreign languages (at least French and German) selected, MP3 > metadata tags for "Artist Name", "Track Title", "Album Title" and > "Track Number" are not filled, so not seen by media applications. > Instead, duplicated custom tags with these identifiers are > created. MM suggests some strings are marked for translation but > used as keys. > > I just tried to Export an MP3 (with user interface in German), > edited the tags, and looked at the file info in WinAmp, > where all the info appeared. > Can anyone give me a hint, how I shall test this one? > (I cannot reproduce it) Check it's not the import back into audacity which is getting confused - import the file in a blank project and see what the metadata editor thinks. Also try ID3 V1 vs V2 tags (does this option still exist?) to see if that is the cause. Who originally reported this? Richard |
|
From: Andreas M. <And...@gm...> - 2007-12-02 19:46:03
|
Richard Ash wrote: > On Sun, 2007-12-02 at 18:46 +0100, Andreas Micheler wrote: > >> I'm a bit confused about this "Essential": >> >> * With foreign languages (at least French and German) selected, MP3 >> metadata tags for "Artist Name", "Track Title", "Album Title" and >> "Track Number" are not filled, so not seen by media applications. >> Instead, duplicated custom tags with these identifiers are >> created. MM suggests some strings are marked for translation but >> used as keys. >> >> I just tried to Export an MP3 (with user interface in German), >> edited the tags, and looked at the file info in WinAmp, >> where all the info appeared. >> Can anyone give me a hint, how I shall test this one? >> (I cannot reproduce it) >> > Check it's not the import back into audacity which is getting confused - > import the file in a blank project and see what the metadata editor > thinks. I just did this. All data which I had edited in a previous Audacity session are present and can be edited. Can you see this bug? > Also try ID3 V1 vs V2 tags (does this option still exist?) to > see if that is the cause. > I don't know where to switch between those. Can you help? > Who originally reported this? > I don't know. Thanks, Andreas |
|
From: Gale A. <ga...@au...> - 2007-12-03 00:47:18
|
| From Andreas Micheler <And...@gm...> | Sun, 02 Dec 2007 20:42:55 +0100 | Subject: [Audacity-devel] some translation issues fixings > >> I'm a bit confused about this "Essential": > >> > >> * With foreign languages (at least French and German) selected, MP3 > >> metadata tags for "Artist Name", "Track Title", "Album Title" and > >> "Track Number" are not filled, so not seen by media applications. > >> Instead, duplicated custom tags with these identifiers are > >> created. MM suggests some strings are marked for translation but > >> used as keys. > >> > >> I just tried to Export an MP3 (with user interface in German), > >> edited the tags, and looked at the file info in WinAmp, > >> where all the info appeared. > >> Can anyone give me a hint, how I shall test this one? > >> (I cannot reproduce it) > >> > > Check it's not the import back into audacity which is getting confused - > > import the file in a blank project and see what the metadata editor > > thinks. > I just did this. > All data which I had edited in a previous Audacity session are present > and can be edited. Are you sure the data is in the same fields and not in newly created custom fields which many apps. won't see? Here is Markus' original post: http://www.nabble.com/MP3-tagging-does-not-work-correctly-in-German-version-t4844183.html#a13859163 > > Also try ID3 V1 vs V2 tags (does this option still exist?) to > > see if that is the cause. > > > I don't know where to switch between those. Can you help? Audacity now always exports as ID3 v2. Gale |
|
From: Martyn S. <mar...@go...> - 2007-12-03 01:08:17
|
Andreas Can you post a zip of the current CVS windows Release build on a web site somewhere please? I can't ftp to my normal place at the moment, and may not be able to for a day or so. Gale Can you please test the current version (assuming Andreas can upload one)? I have a feeling that this is now fixed, but can't be sure. Martyn Gale Andrews wrote: > | From Andreas Micheler <And...@gm...> > | Sun, 02 Dec 2007 20:42:55 +0100 > | Subject: [Audacity-devel] some translation issues fixings >>>> I'm a bit confused about this "Essential": >>>> >>>> * With foreign languages (at least French and German) selected, MP3 >>>> metadata tags for "Artist Name", "Track Title", "Album Title" and >>>> "Track Number" are not filled, so not seen by media applications. >>>> Instead, duplicated custom tags with these identifiers are >>>> created. MM suggests some strings are marked for translation but >>>> used as keys. >>>> >>>> I just tried to Export an MP3 (with user interface in German), >>>> edited the tags, and looked at the file info in WinAmp, >>>> where all the info appeared. >>>> Can anyone give me a hint, how I shall test this one? >>>> (I cannot reproduce it) >>>> >>> Check it's not the import back into audacity which is getting confused - >>> import the file in a blank project and see what the metadata editor >>> thinks. >> I just did this. >> All data which I had edited in a previous Audacity session are present >> and can be edited. > > Are you sure the data is in the same fields and not in newly created > custom fields which many apps. won't see? Here is Markus' original post: > http://www.nabble.com/MP3-tagging-does-not-work-correctly-in-German-version-t4844183.html#a13859163 > > >>> Also try ID3 V1 vs V2 tags (does this option still exist?) to >>> see if that is the cause. >>> >> I don't know where to switch between those. Can you help? > > Audacity now always exports as ID3 v2. > > > Gale > > ------------------------------------------------------------------------- > SF.Net email is sponsored by: The Future of Linux Business White Paper > from Novell. From the desktop to the data center, Linux is going > mainstream. Let it simplify your IT future. > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 > _______________________________________________ > Audacity-devel mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
|
From: Andreas M. <And...@gm...> - 2007-12-03 02:30:41
|
Martyn Shaw wrote: > Andreas > Can you post a zip of the current CVS windows Release build on a web > site somewhere please? I can't ftp to my normal place at the moment, > and may not be able to for a day or so. > Sure, this is done now, with two exceptions: 1) I use my version of TimeTextCtrl.cpp with the new translation code, which I've already posted in the forum, in this build. So if this does not work well enough I don't need to revert it on CVS, I then just can download it again from CVS. 2) I had to #include <wx/log.h> into ExpandingToolBar.cpp to get it compile in Release mode. I hope 1) and 2) are not too distracting. The .zip file is now here: <http://www.physik.uni-augsburg.de/~micheler/audacity-1.3.4-windows-CVS.zip> Cheers, Andreas |
|
From: Gale A. <ga...@au...> - 2007-12-03 09:28:14
|
| From Andreas Micheler <And...@gm...> | Mon, 03 Dec 2007 03:31:00 +0100 | Subject: [Audacity-devel] MP3 tagging does not work correctly in German version > Martyn Shaw wrote: > > Andreas > > Can you post a zip of the current CVS windows Release build on a web > > site somewhere please? I can't ftp to my normal place at the moment, > > and may not be able to for a day or so. > > > Sure, this is done now, with two exceptions: > > 1) I use my version of TimeTextCtrl.cpp with the new translation code, > which I've already posted in the forum, in this build. > So if this does not work well enough I don't need to revert it on CVS, > I then just can download it again from CVS. > > 2) I had to > #include <wx/log.h> > into ExpandingToolBar.cpp to get it compile in Release mode. > > > The .zip file is now here: > <http://www.physik.uni-augsburg.de/~micheler/audacity-1.3.4-windows-CVS.zip> Andreas I am not quite sure why the problem should have been cleared - is it because of the tidying you have done with translations? Anyway, the build you posted won't export MP3s. I get an invalid sample rate error and the drop down box where you choose the rate is not populated. I am exporting at standard 44100 Hz/128 kbps which should work. I have tested only in German and FLAC is OK. WAV is not quite right - I filled in all seven default fields in the Metadata Editor and exported the WAV, but when I reimport the WAV into Audacity the following fields are blank: "Titel der CD" "Jahr" "Bemerkungen" By the way, why "CD" in "Titel der CD"? I'll be glad to test MP3 in various players (VLC, iTunes, Foobar etc.) if you can get the export working. Thanks Gale |
|
From: Martyn S. <mar...@go...> - 2007-12-03 23:44:45
|
Gale Andrews wrote: > | From Andreas Micheler <And...@gm...> > | Mon, 03 Dec 2007 03:31:00 +0100 ... > Anyway, the build you posted won't export MP3s. I get an invalid sample > rate error and the drop down box where you choose the rate is not > populated. I am exporting at standard 44100 Hz/128 kbps which should > work. It seems to work OK for me. > I have tested only in German and FLAC is OK. WAV is not quite right - I > filled in all seven default fields in the Metadata Editor and exported the > WAV, but when I reimport the WAV into Audacity the following fields are > blank: > > "Titel der CD" > "Jahr" > "Bemerkungen" and these are filled in as well. I replaced the exe in my build-tree with Andreas's one, what can be the difference? Martyn |
|
From: Andreas M. <And...@gm...> - 2007-12-04 18:14:48
|
Hallo Gale, > I am not quite sure why the problem should have been cleared - is it > because of the tidying you have done with translations? > Yes, I think so. > Anyway, the build you posted won't export MP3s. Ah, I saw this bug already! It must have to do with my translations. You can get around it by first clicking on the Options button in the export dialog. I'll try to repair it instantly! Thanks, Andreas |
|
From: Gale A. <ga...@au...> - 2007-12-04 19:26:55
|
| From Martyn Shaw <mar...@go...> | Mon, 03 Dec 2007 23:46:59 +0000 | Subject: [Audacity-devel] MP3 tagging does not work correctly in German version > Gale Andrews wrote: > > | From Andreas Micheler <And...@gm...> > > | Mon, 03 Dec 2007 03:31:00 +0100 > ... > > Anyway, the build you posted won't export MP3s. I get an invalid sample > > rate error and the drop down box where you choose the rate is not > > populated. I am exporting at standard 44100 Hz/128 kbps which should > > work. > > It seems to work OK for me. All I can do is drop Andreas' exe in my Audacity folder from which I launch the other 1.3.x versions (or for this purpose, OK, launch it as is).. I still cannot export MP3 with the one Andreas posted on either of my machines. > > > I have tested only in German and FLAC is OK. WAV is not quite right - I > > filled in all seven default fields in the Metadata Editor and exported the > > WAV, but when I reimport the WAV into Audacity the following fields are > > blank: > > > > "Titel der CD" > > "Jahr" > > "Bemerkungen" > > and these are filled in as well. > > I replaced the exe in my build-tree with Andreas's one, what can be > the difference? Sorry for the stupid question but are you both exiting Audacity before importing the exported file? Otherwise Audacity will simply display the same tags that you exported with. Gale |
|
From: Andreas M. <And...@gm...> - 2007-12-04 19:59:07
|
Hallo Gale! Gale Andrews wrote: >> I replaced the exe in my build-tree with Andreas's one, what can be >> the difference? >> > Sorry for the stupid question but are you both exiting Audacity before > importing the exported file? I exited before importing again. I just did this again and it worked. Cheers, Andreas |
|
From: Martyn S. <mar...@go...> - 2007-12-04 22:48:11
|
Gale Andrews wrote: ... >>> I have tested only in German and FLAC is OK. WAV is not quite right - I >>> filled in all seven default fields in the Metadata Editor and exported the >>> WAV, but when I reimport the WAV into Audacity the following fields are >>> blank: >>> >>> "Titel der CD" >>> "Jahr" >>> "Bemerkungen" >> and these are filled in as well. >> >> I replaced the exe in my build-tree with Andreas's one, what can be >> the difference? > > Sorry for the stupid question but are you both exiting Audacity before > importing the exported file? Otherwise Audacity will simply display > the same tags that you exported with. Not a stupid question and I'm guilty of not closing and reopening, sorry. This is not unique to the German language version. And it's not a bug, as such. From my reading, wav files do not support ID3 tags. They do have some Info tags and I believe that between ExportPCM and sndfile the best mapping has been done to turn MP3-type info into wav-type info. Artist, Title, Year and Comments get written, as do Copyright and Software. Do you want to try your test again (using Andreas's recent build) and see if I am right? Martyn http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/WAV.html > > > Gale > > > |
|
From: Gale A. <ga...@au...> - 2007-12-05 08:27:15
|
| From Martyn Shaw <mar...@go...> | Tue, 04 Dec 2007 22:50:26 +0000 | Subject: [Audacity-devel] MP3 tagging does not work correctly in German version > >>> I have tested only in German and FLAC is OK. WAV is not quite right - I > >>> filled in all seven default fields in the Metadata Editor and exported the > >>> WAV, but when I reimport the WAV into Audacity the following fields are > >>> blank: > >>> > >>> "Titel der CD" > >>> "Jahr" > >>> "Bemerkungen" > > This is not unique to the German language version. And it's not a > bug, as such. From my reading, wav files do not support ID3 tags. > They do have some Info tags and I believe that between ExportPCM and > sndfile the best mapping has been done to turn MP3-type info into > wav-type info. Artist, Title, Year and Comments get written, as do > Copyright and Software. Are we then listing Album Title, Track number and Genre in the Editor as they are there for the other formats, but then deliberately (or only accidentally) suppressing them for WAV? I can't find any concrete definition of what should be in WAV metadata but if I look at say BWF it seems to depend on what fields the applications that support the format have decided to include. Even so, might some people find all seven fields useful even if only Audacity can read them? Or wouldn't it be better not to present all the fields if we can't fill them? Gale |
|
From: Martyn S. <mar...@go...> - 2007-12-05 23:34:42
|
Gale Andrews wrote: > | From Martyn Shaw <mar...@go...> > | Tue, 04 Dec 2007 22:50:26 +0000 > | Subject: [Audacity-devel] MP3 tagging does not work correctly in German version >>>>> I have tested only in German and FLAC is OK. WAV is not quite right - I >>>>> filled in all seven default fields in the Metadata Editor and exported the >>>>> WAV, but when I reimport the WAV into Audacity the following fields are >>>>> blank: >>>>> >>>>> "Titel der CD" >>>>> "Jahr" >>>>> "Bemerkungen" >> This is not unique to the German language version. And it's not a >> bug, as such. From my reading, wav files do not support ID3 tags. >> They do have some Info tags and I believe that between ExportPCM and >> sndfile the best mapping has been done to turn MP3-type info into >> wav-type info. Artist, Title, Year and Comments get written, as do >> Copyright and Software. > > Are we then listing Album Title, Track number and Genre in the Editor as > they are there for the other formats, but then deliberately (or only > accidentally) suppressing them for WAV? Kind of. The Metadata editor can be opened without the type of file to be exported having been decided on, so we can't do something special depending what that decision will be (unless we can see into the users minds - something I'm working on for post-1.4). (I am having trouble with it because it appears that some users do not have anything on their minds.) Since we don't (always) know the export type, we have to let people add things willy-nilly, then use what we can during any subsequent export. People may export the same audio in several formats, one after the other. > I can't find any concrete > definition of what should be in WAV metadata but if I look at say BWF it > seems to depend on what fields the applications that support the format > have decided to include. The link I gave may not be definitive but looks quite good to me http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/WAV.html Martyn > > Even so, might some people find all seven fields useful even if only > Audacity can read them? Or wouldn't it be better not to present > all the fields if we can't fill them? > > > Gale > > > > |
