Thread: [Audacity-devel] Visual Studio 7.1 compatibility patch - again
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Asger O. A. <aal...@la...> - 2004-07-17 08:34:16
Attachments:
vs71.patch
|
Hi, Attached a new, fresh patch against the audacity-1.2 branch that will make the source compile with the stricter VS.NET 7.1 compiler. The changes resolve ambiguities regarding int, float and double overloads of the pow and log functions, as well as two include problems in soundtouch. The patch should be safe, and bring the source closer to standards compliance. (There are still 424 warnings about loss of precision due to automatic conversions from double to long/int/float, from int to float, and so on all over the code, but I only included the absolute necessary changes in the patch.) With this patch applied, you can compile audacity with the 7.1 compiler by letting studio automatically upgrade the .dsp project files, and then manually fixing the soundtouch project file: Remove all the .cc files from the project, and re-add then manually (except for the mmx_gcc.cc file.) which for some reason is not converted correctly. You might also have trouble with the precompiled headers in the Audacity project itself - you can fix that by turning off the precompiled headers for that project. Finally, in the release build configuration, you have to remove "libci.lib" from the input linker setting. When that is done, everything works just great. The resulting binary using the default configuration of libraries in CVS is 4816 kb. Regards, Asger Ottar Alstrup |
From: Vaughan J. <vjo...@co...> - 2004-07-19 00:33:59
|
Thanks, Asger. I've applied your patch and committed it to CVS in HEAD and the AUDACITY_1_2 branch. For HEAD, the step you mention for SoundTouch should not be necessary, because HEAD uses SoundTouch v1.2.1, which has the .cpp filetype instead of .cc. -Vaughan Asger Ottar Alstrup wrote: > Hi, > > Attached a new, fresh patch against the audacity-1.2 branch that will > make the source compile with the stricter VS.NET 7.1 compiler. The > changes resolve ambiguities regarding int, float and double overloads > of the pow and log functions, as well as two include problems in > soundtouch. > > The patch should be safe, and bring the source closer to standards > compliance. (There are still 424 warnings about loss of precision due > to automatic conversions from double to long/int/float, from int to > float, and so on all over the code, but I only included the absolute > necessary changes in the patch.) > > With this patch applied, you can compile audacity with the 7.1 > compiler by letting studio automatically upgrade the .dsp project > files, and then manually fixing the soundtouch project file: Remove > all the .cc files from the project, and re-add then manually (except > for the mmx_gcc.cc file.) which for some reason is not converted > correctly. > > You might also have trouble with the precompiled headers in the > Audacity project itself - you can fix that by turning off the > precompiled headers for that project. > > Finally, in the release build configuration, you have to remove > "libci.lib" from the input linker setting. > > When that is done, everything works just great. The resulting binary > using the default configuration of libraries in CVS is 4816 kb. > > Regards, > Asger Ottar Alstrup |