Thread: [Audacity-devel] Noise removal, spurious clips and crash
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Bill W. <bi...@go...> - 2009-11-21 04:46:10
|
Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) Mac 10.5.8, G5 (PPC) New Project Generate tone 10 seconds Edit > Duplicate twice to create four tracks Drag the clips on tracks 2, 3 and 4 so that the clips are staggered and snap end-to-end Select some silence on any track Effect > Noise Removal > Get Noise Profle Edit > Select > All Effect > Noise Removal > OK All clips are lined up to zero As a bonus, two spurious clips are created at the ends of tracks 1 and 2 Zoom in on one of the spurious clips Click in one of the spurious clips with the selection tool Switch to the time shift tool Try to move the spurious clip - Audacity crashes Tried this three time with exactly the same result every time. Crash report attached. -- Bill |
From: Ed M. <edg...@wa...> - 2009-11-21 07:32:28
|
I can confirm everything until the last. For me I am able to select both of the spurious clips separately and move them around with the timeshift tool multiple times with no problems. --Ed From: Bill Wharrie [mailto:bi...@go...] Sent: Friday, November 20, 2009 8:46 PM To: aud...@li... Subject: [Audacity-devel] Noise removal, spurious clips and crash Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) Mac 10.5.8, G5 (PPC) New Project Generate tone 10 seconds Edit > Duplicate twice to create four tracks Drag the clips on tracks 2, 3 and 4 so that the clips are staggered and snap end-to-end Select some silence on any track Effect > Noise Removal > Get Noise Profle Edit > Select > All Effect > Noise Removal > OK All clips are lined up to zero As a bonus, two spurious clips are created at the ends of tracks 1 and 2 Zoom in on one of the spurious clips Click in one of the spurious clips with the selection tool Switch to the time shift tool Try to move the spurious clip - Audacity crashes Tried this three time with exactly the same result every time. Crash report attached. -- Bill |
From: Stevethefiddle <ste...@gm...> - 2009-11-21 14:03:27
|
Confirmed on Linux (Ubuntu) with 1.3.10, though I would describe the problem differently. When Noise Removal is applied to multiple tracks, white space preceding the first clip in a track, that is within the selected region, is deleted (other white space is converted to silence). The "spurious clips" appears to be a consequence of this. I don't see the crashing issue. Steve Ed Musgrove-2 wrote: > > I can confirm everything until the last. For me I am able to select both > of > the spurious clips separately and move them around with the timeshift tool > multiple times with no problems. > > > > --Ed > > > > From: Bill Wharrie [mailto:bi...@go...] > Sent: Friday, November 20, 2009 8:46 PM > To: aud...@li... > Subject: [Audacity-devel] Noise removal, spurious clips and crash > > > > Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) > > Mac 10.5.8, G5 (PPC) > > > > New Project > > Generate tone 10 seconds > > Edit > Duplicate twice to create four tracks > > Drag the clips on tracks 2, 3 and 4 so that the clips are staggered and > snap > end-to-end > > Select some silence on any track > > Effect > Noise Removal > Get Noise Profle > > Edit > Select > All > > Effect > Noise Removal > OK > > All clips are lined up to zero > > As a bonus, two spurious clips are created at the ends of tracks 1 and 2 > > Zoom in on one of the spurious clips > > Click in one of the spurious clips with the selection tool > > Switch to the time shift tool > > Try to move the spurious clip - Audacity crashes > > > > Tried this three time with exactly the same result every time. > > > > Crash report attached. > > > > -- Bill > > -- View this message in context: http://n2.nabble.com/Noise-removal-spurious-clips-and-crash-tp4041632p4042687.html Sent from the audacity-devel mailing list archive at Nabble.com. |
From: Bill W. <bi...@go...> - 2009-11-21 16:33:10
|
On 20-Nov-09, at 11:45 PM, Bill Wharrie wrote: > Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) > Mac 10.5.8, G5 (PPC) > > New Project > Generate tone 10 seconds > Edit > Duplicate twice to create four tracks > Drag the clips on tracks 2, 3 and 4 so that the clips are staggered > and snap end-to-end > Select some silence on any track > Effect > Noise Removal > Get Noise Profle > Edit > Select > All > Effect > Noise Removal > OK > All clips are lined up to zero > As a bonus, two spurious clips are created at the ends of tracks 1 > and 2 > Zoom in on one of the spurious clips > Click in one of the spurious clips with the selection tool > Switch to the time shift tool > Try to move the spurious clip - Audacity crashes > If I save the project at any time before trying to move one of the spurious clips the crash does not occur. -- Bill |
From: Bill W. <bi...@go...> - 2009-11-21 16:36:29
|
On 21-Nov-09, at 9:03 AM, Stevethefiddle wrote: > > Confirmed on Linux (Ubuntu) with 1.3.10, though I would describe the > problem > differently. > > When Noise Removal is applied to multiple tracks, white space > preceding the > first clip in a track, that is within the selected region, is deleted > (other white space is converted to silence). Are you saying this is normal and expected behaviour? > The "spurious clips" appears to > be a consequence of this. Why are spurious clips created on tracks 1 and 2, and why is the length of the clips on tracks 3 and 4 extended by 344 samples? -- Bill |
From: Al D. <bus...@gm...> - 2009-11-21 18:07:48
|
On Saturday 21 November 2009 09:36:12 Bill Wharrie wrote: > On 21-Nov-09, at 9:03 AM, Stevethefiddle wrote: > > Confirmed on Linux (Ubuntu) with 1.3.10, though I would describe > > the problem > > differently. > > > > When Noise Removal is applied to multiple tracks, white space > > preceding the > > first clip in a track, that is within the selected region, is > > deleted (other white space is converted to silence). > > Are you saying this is normal and expected behaviour? > > > The "spurious clips" appears to > > be a consequence of this. > > Why are spurious clips created on tracks 1 and 2, and why is the > length of the clips on tracks 3 and 4 extended by 344 samples? > I think what's happening is that the output from noise removal is a little longer than the input (perhaps due to how the filters work -- I'm getting just 8 samples myself). And when it pastes back into the first and second tracks there were previous clip boundaries at 30s, so ClearAndPaste() wisely goes and adds a split line there. It is a bit concerning that the output is longer than the input for noise removal... it could very well cause timing problems if applied in the middle of tracks. I will look into this. > -- Bill > > > ------------------------------------------------------------------- > ----------- Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day trial. Simplify your report design, > integration and deployment - and focus on what you do best, core > application coding. Discover what's new with Crystal Reports now. > http://p.sf.net/sfu/bobj-july > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Al D. <bus...@gm...> - 2009-11-21 18:02:28
|
On Friday 20 November 2009 21:45:57 Bill Wharrie wrote: > Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) > Mac 10.5.8, G5 (PPC) > > New Project > Generate tone 10 seconds > Edit > Duplicate twice to create four tracks > Drag the clips on tracks 2, 3 and 4 so that the clips are staggered > and snap end-to-end > Select some silence on any track > Effect > Noise Removal > Get Noise Profle > Edit > Select > All > Effect > Noise Removal > OK > All clips are lined up to zero > As a bonus, two spurious clips are created at the ends of tracks 1 > and 2 Zoom in on one of the spurious clips > Click in one of the spurious clips with the selection tool > Switch to the time shift tool > Try to move the spurious clip - Audacity crashes > > Tried this three time with exactly the same result every time. > In my debug builds I was hitting some assertions essentially coming down to Sequence::GetWaveDisplay() trying to call Sequence::FindBlock() with an invalid sample count. This does cause a crash... so I stopped it from doing that. As far as I can tell this solves the problem. It's not always easy to get that condition to occur. At some scroll positions and zoom levels it occurs readily, on others it doesn't. But I think I might have fixed this crash. Now for the problem that the whitespace gets killed, and that the extra clips are created. - Al > Crash report attached. > > -- Bill > |
From: Al D. <bus...@gm...> - 2009-11-22 02:24:17
|
On Saturday 21 November 2009 11:03:28 Al Dimond wrote: > On Friday 20 November 2009 21:45:57 Bill Wharrie wrote: > > Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) > > Mac 10.5.8, G5 (PPC) > > > > New Project > > Generate tone 10 seconds > > Edit > Duplicate twice to create four tracks > > Drag the clips on tracks 2, 3 and 4 so that the clips are > > staggered and snap end-to-end > > Select some silence on any track > > Effect > Noise Removal > Get Noise Profle > > Edit > Select > All > > Effect > Noise Removal > OK > > All clips are lined up to zero > > As a bonus, two spurious clips are created at the ends of tracks > > 1 and 2 Zoom in on one of the spurious clips > > Click in one of the spurious clips with the selection tool > > Switch to the time shift tool > > Try to move the spurious clip - Audacity crashes > > > > Tried this three time with exactly the same result every time. > > In my debug builds I was hitting some assertions essentially coming > down to Sequence::GetWaveDisplay() trying to call > Sequence::FindBlock() with an invalid sample count. This does > cause a crash... so I stopped it from doing that. As far as I can > tell this solves the problem. > > It's not always easy to get that condition to occur. At some > scroll positions and zoom levels it occurs readily, on others it > doesn't. But I think I might have fixed this crash. Now for the > problem that the whitespace gets killed, and that the extra clips > are created. > I think I should comment a little more on the significance of this change. I made two changes. The first is relatively insignificant: when you are zoomed in very close (around 1 sample per pixel) and looking at the start of a clip in the middle of the screen, the waveform was being multiplied by out-of-bounds envelope values. It was unlikely to be noticed except when running debug builds, because of an assertion -- it definitely wouldn't have crashed, envelope code handles out-of-bounds lookups just fine. The second change may have fixed the P2 (Projects crash when applying repeated effects on zoomed in regions towards the end of audio tracks). What I know is that it fixed a crash (out-of-bounds array index) that can occur in rare cases when redrawing the end of clips. As far as I can tell it wouldn't be limited to the time-shift tool, time-shifting just forces clips to be redrawn in a variety of interesting ways. It could be triggered when scrolling, or even on a zoom or initial drawing of a clip if the clip was very short. The trouble is that we don't know whether this is the issue that people have been reporting or not. - Al > - Al > > > Crash report attached. > > > > -- Bill > |
From: Bill W. <bi...@go...> - 2009-11-22 05:50:02
|
On 21-Nov-09, at 9:25 PM, Al Dimond wrote: > On Saturday 21 November 2009 11:03:28 Al Dimond wrote: >> On Friday 20 November 2009 21:45:57 Bill Wharrie wrote: >>> Tested with Audacity 1.3.10-alpha-Nov 20 2009 (Unicode) >>> Mac 10.5.8, G5 (PPC) >>> >>> New Project >>> Generate tone 10 seconds >>> Edit > Duplicate twice to create four tracks >>> Drag the clips on tracks 2, 3 and 4 so that the clips are >>> staggered and snap end-to-end >>> Select some silence on any track >>> Effect > Noise Removal > Get Noise Profle >>> Edit > Select > All >>> Effect > Noise Removal > OK >>> All clips are lined up to zero >>> As a bonus, two spurious clips are created at the ends of tracks >>> 1 and 2 Zoom in on one of the spurious clips >>> Click in one of the spurious clips with the selection tool >>> Switch to the time shift tool >>> Try to move the spurious clip - Audacity crashes >>> >>> Tried this three time with exactly the same result every time. >> >> In my debug builds I was hitting some assertions essentially coming >> down to Sequence::GetWaveDisplay() trying to call >> Sequence::FindBlock() with an invalid sample count. This does >> cause a crash... so I stopped it from doing that. As far as I can >> tell this solves the problem. >> >> It's not always easy to get that condition to occur. At some >> scroll positions and zoom levels it occurs readily, on others it >> doesn't. But I think I might have fixed this crash. Now for the >> problem that the whitespace gets killed, and that the extra clips >> are created. >> > > I think I should comment a little more on the significance of this > change. I made two changes. The first is relatively insignificant: > when you are zoomed in very close (around 1 sample per pixel) and > looking at the start of a clip in the middle of the screen, the > waveform was being multiplied by out-of-bounds envelope values. It > was unlikely to be noticed except when running debug builds, because > of an assertion -- it definitely wouldn't have crashed, envelope code > handles out-of-bounds lookups just fine. > > The second change may have fixed the P2 (Projects crash when applying > repeated effects on zoomed in regions towards the end of audio > tracks). > What I know is that it fixed a crash (out-of-bounds array index) that > can occur in rare cases when redrawing the end of clips. As far as I > can tell it wouldn't be limited to the time-shift tool, time-shifting > just forces clips to be redrawn in a variety of interesting ways. It > could be triggered when scrolling, or even on a zoom or initial > drawing of a clip if the clip was very short. The trouble is that we > don't know whether this is the issue that people have been reporting > or not. Whatever you did, Al, the case I originally reported no longer crashes. Audacity ® 1.3.10-alpha-Nov 22 2009 (Unicode) -- Bill |