Thread: [Audacity-devel] Lost focus and keyboard access
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2013-10-15 06:30:46
|
I'm seeing a "lost focus" problem with svn head on Linux. Steps to reproduce: 1) Launch Audacity. 2) Generate menu > Tone. At this point a track is created and the Tone Generator interface pops up, but there is no yellow highlighting around the track. 3) Click "OK" or press "Enter" to generate a tone. There is still no highlighting around the track. Cursor keys now do not work. Spacebar does not start play. CTRL + SHIFT + F6 does not work. 4) Click on the Track. The Selection is replaced by a line cursor as expected, but still no Yellow highlighting. Cursor keys still do not work. Spacebar does not start play. Ctrl+Shift+F6 still does not work. 5) Click on the Selection Toolbar. It is now possible to Tab through the Selection Toolbar controls. Spacebar Now works. Ctrl+Shift+F6 now works. 6) Use Ctrl+Shift+F6 to move focus to the Tracks Panel. The track is now highlighted with a yellow border.. Cursor keys now work Spacebar Now works. 7) Press the Context key to open the track drop-down menu. The drop-down menu opens. 8) Apply any option from the drop-down menu or press Escape to exit the menu. We are now back to step 3. Cursor keys now do not work. Spacebar does not start play. CTRL + SHIFT + F6 does not work. The problem occurs with both debug and release builds and with default preferences. The problem does not occur with Audacity 2.0.4-alpha-June30. I suspect that it is a very recent fault. I'll try to narrow it down further tomorrow. Needless to say, this destroys accessibility on Linux. Steve |
From: Leland <le...@au...> - 2013-10-15 06:51:33
|
On 10/15/2013 1:30 AM, Steve the Fiddle wrote: > I'm seeing a "lost focus" problem with svn head on Linux. Bummer. I see them too on Windows, but accessibility still works. I know which change did it. It's the one that made the dialogs have focus which is a good thing, but not at the expense of having the track panel lose focus. I'll see if there's an obvious fix (because we do want our cake and eat it too!), but we might just have to revert that change. Leland |
From: Leland <le...@au...> - 2013-10-15 06:54:32
|
On 10/15/2013 1:51 AM, Leland wrote: > On 10/15/2013 1:30 AM, Steve the Fiddle wrote: >> I'm seeing a "lost focus" problem with svn head on Linux. > Bummer. I see them too on Windows, but accessibility still works. I > know which change did it. It's the one that made the dialogs have focus > which is a good thing, but not at the expense of having the track panel > lose focus. > > I'll see if there's an obvious fix (because we do want our cake and eat > it too!), but we might just have to revert that change. Or maybe not since that change was ifdef()d for wxGTK only. Leland |
From: Steve t. F. <ste...@gm...> - 2013-10-15 06:52:32
|
The problem does not occur with r12666. Steve On 15 October 2013 07:30, Steve the Fiddle <ste...@gm...> wrote: > I'm seeing a "lost focus" problem with svn head on Linux. > > Steps to reproduce: > > 1) Launch Audacity. > 2) Generate menu > Tone. At this point a track is created and the Tone > Generator interface pops up, but there is no yellow highlighting > around the track. > 3) Click "OK" or press "Enter" to generate a tone. There is still no > highlighting around the track. > Cursor keys now do not work. > Spacebar does not start play. > CTRL + SHIFT + F6 does not work. > > 4) Click on the Track. The Selection is replaced by a line cursor as > expected, but still no Yellow highlighting. > Cursor keys still do not work. > Spacebar does not start play. > Ctrl+Shift+F6 still does not work. > > 5) Click on the Selection Toolbar. It is now possible to Tab through > the Selection Toolbar controls. > Spacebar Now works. > Ctrl+Shift+F6 now works. > > 6) Use Ctrl+Shift+F6 to move focus to the Tracks Panel. The track is > now highlighted with a yellow border.. > Cursor keys now work > Spacebar Now works. > > 7) Press the Context key to open the track drop-down menu. The > drop-down menu opens. > > 8) Apply any option from the drop-down menu or press Escape to exit the menu. > We are now back to step 3. > Cursor keys now do not work. > Spacebar does not start play. > CTRL + SHIFT + F6 does not work. > > > The problem occurs with both debug and release builds and with default > preferences. > > The problem does not occur with Audacity 2.0.4-alpha-June30. > I suspect that it is a very recent fault. I'll try to narrow it down > further tomorrow. > > Needless to say, this destroys accessibility on Linux. > > Steve |
From: Leland <le...@au...> - 2013-10-15 06:58:13
|
On 10/15/2013 1:52 AM, Steve the Fiddle wrote: > The problem does not occur with r12666. So it is the dialog focus "fix". I could SWEAR I saw some focus messages on Windows. I don't know, maybe not enough sleep. Leland |
From: Steve t. F. <ste...@gm...> - 2013-10-15 07:17:57
|
Confirmed, it's r12667. The problem does not occur with R12666 but does occur with r12667. As Leland said, the r12667 commit is in #if defined(__WXGTK__) For accessibility on Linux it would be far better if this could be fixed rather than just reverted. Steve On 15 October 2013 07:58, Leland <le...@au...> wrote: > On 10/15/2013 1:52 AM, Steve the Fiddle wrote: >> The problem does not occur with r12666. > So it is the dialog focus "fix". I could SWEAR I saw some focus > messages on Windows. I don't know, maybe not enough sleep. > > Leland |
From: Leland <le...@au...> - 2013-10-15 07:27:33
Attachments:
focushope.patch
|
On 10/15/2013 2:17 AM, Steve the Fiddle wrote: > Confirmed, it's r12667. > The problem does not occur with R12666 but does occur with r12667. > > As Leland said, the r12667 commit is in > #if defined(__WXGTK__) > > For accessibility on Linux it would be far better if this could be > fixed rather than just reverted. Can you test the attached patch? Thanks, Leland |
From: Leland <le...@au...> - 2013-10-15 13:16:13
|
On 10/15/2013 2:27 AM, Leland wrote: > On 10/15/2013 2:17 AM, Steve the Fiddle wrote: >> Confirmed, it's r12667. >> The problem does not occur with R12666 but does occur with r12667. >> >> As Leland said, the r12667 commit is in >> #if defined(__WXGTK__) >> >> For accessibility on Linux it would be far better if this could be >> fixed rather than just reverted. > Can you test the attached patch? > I've gone ahead and committed it. It appears to correct the issues here and it's definitely better than after r12667. It restricts focus setting to wxDialogs only, so this prevents it from "overriding" the focus setting done by Project.cpp for the main window. Leland |
From: Steve t. F. <ste...@gm...> - 2013-10-15 15:19:01
|
On 15 October 2013 14:16, Leland <le...@au...> wrote: > On 10/15/2013 2:27 AM, Leland wrote: >> On 10/15/2013 2:17 AM, Steve the Fiddle wrote: >>> Confirmed, it's r12667. >>> The problem does not occur with R12666 but does occur with r12667. >>> >>> As Leland said, the r12667 commit is in >>> #if defined(__WXGTK__) >>> >>> For accessibility on Linux it would be far better if this could be >>> fixed rather than just reverted. >> Can you test the attached patch? >> > I've gone ahead and committed it. It appears to correct the issues here > and it's definitely better than after r12667. It restricts focus > setting to wxDialogs only, so this prevents it from "overriding" the > focus setting done by Project.cpp for the main window. Tested with both release and debug builds on Debian. No problem found. Appears to be fixed. Thanks Leland. Steve > > Leland |
From: Gale (A. Team) <ga...@au...> - 2013-10-15 18:09:35
|
It's OK for me on Ubuntu, too. Tabbing into effects still works and focus is still on the track after running the effect. Thanks for spotting the issue, Steve. Gale -- View this message in context: http://audacity.238276.n2.nabble.com/Lost-focus-and-keyboard-access-tp7559944p7559958.html Sent from the audacity-devel mailing list archive at Nabble.com. |
From: Vaughan J. <va...@au...> - 2013-10-15 19:22:49
|
Thanks, guys, for following this one up! I assume it doesn't affect the manual, so it's good to go. - V On 10/15/2013 11:09 AM, Gale (Audacity Team) wrote: > It's OK for me on Ubuntu, too. Tabbing into effects still works and focus is > still > on the track after running the effect. > > Thanks for spotting the issue, Steve. > > > Gale > > |