Thread: Re: [Audacity-devel] Bug Fix for Bug Number 62 and 476
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2012-08-17 00:18:38
|
Sorry, but your patch is not acceptable. For instance, for Play you added conditions AudioIONotBusyFlag | TracksExistFlag. But there is value in having Play enabled when audio IO is busy. Try it. And you changed several AudioIOBusyFlag to AudioIONotBusyFlag... unlikely to be correct. Also, when you submit a patch for review, it's better if it has only the necessary functional changes, i.e., in this case, not a lot of indentation changes. As this is P4, I am not going to work on a correct fix for 2.0.2. - Vaughan On 8/16/2012 5:10 AM, Gaurav Agarwal wrote: > Hi > > If there is no Track, some options like Play, Pause, stop etc supposed > to be grayed in "control toolbar" and in "transport menu". Some of these > problems were reported in Bug No 62, where as some similar problems were > reported in 476. > > So final bug becomes: > > In Control toolbar > > 1) Play, Pause Buttons in Control toolbar should be grayed, if there is > no track. > > In Menu->Transport > > 1) Play, Loop Play, Pause, Stop, Skip To Start, Skip to End should also > be grayed, if there is no track.** > > In Menu -> Track > > 1) Mute All Tracks, UnMute Alll Tracks should also be grayed, if there > is no track. > 2) Renaming of UnMute to Unmute. > > > Please find Attached Patch for all these fix. > > > Thanks > Gaurav Agarwal > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |