Thread: [Audacity-devel] Run Benchmark removed from Release builds
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Gale (A. Team) <ga...@au...> - 2009-05-04 03:25:55
|
Hi Leland When you removed Screenshot Tools from #ifdef __WXDEBUG__ in Menus.cpp rev.1.463 so they could be in release builds as well, you put Run Benchmark inside that #ifdef instead. I know the Benchmark isn't ideal but it's referenced in the Manual so I assumed it was going into 1.4? These are the relevant lines in the current Menus.cpp: 966 if( !mCleanSpeechMode ) 967 { 968 c->AddSeparator(); 969 c->AddItem(wxT("Screenshot"), _("&Screenshot Tools..."), FN(OnScreenshot)); 970 #ifdef __WXDEBUG__ 971 c->AddSeparator(); 972 c->AddItem(wxT("Benchmark"), _("&Run Benchmark..."), FN(OnBenchmark)); 973 #endif 974 c->AddSeparator(); 975 c->AddItem(wxT("DeviceInfo"), _("&Audio Device Info..."), FN(OnAudioDeviceInfo)); Thanks Gale -- View this message in context: http://n2.nabble.com/Run-Benchmark-removed-from-Release-builds-tp2785466p2785466.html Sent from the audacity-devel mailing list archive at Nabble.com. |
From: Gale (A. Team) <ga...@au...> - 2009-05-29 00:10:27
|
Gale (Audacity Team) wrote: > Hi Leland > When you removed Screenshot Tools from #ifdef __WXDEBUG__ in Menus.cpp > rev.1.463 > so they could be in release builds as well, you put Run Benchmark inside > that #ifdef > instead. I know the Benchmark isn't ideal but it's referenced in the > Manual so I assumed > it was going into 1.4? > > These are the relevant lines in the current Menus.cpp: > > 966 if( !mCleanSpeechMode ) > 967 { > 968 c->AddSeparator(); > 969 c->AddItem(wxT("Screenshot"), _("&Screenshot Tools..."), > FN(OnScreenshot)); > 970 #ifdef __WXDEBUG__ > 971 c->AddSeparator(); > 972 c->AddItem(wxT("Benchmark"), _("&Run Benchmark..."), > FN(OnBenchmark)); > 973 #endif > 974 c->AddSeparator(); > 975 c->AddItem(wxT("DeviceInfo"), _("&Audio Device Info..."), > FN(OnAudioDeviceInfo)); Could we have a decision on this please. Is "Run Benchmark" in Debug only (-1 here); and if removing it from Beta was a mistake, is it in 2.0? Gale -- View this message in context: http://n2.nabble.com/Run-Benchmark-removed-from-Release-builds-tp2785466p2991175.html Sent from the audacity-devel mailing list archive at Nabble.com. |
From: Leland <le...@au...> - 2009-05-29 00:45:29
|
Gale (Audacity Team) wrote: > Gale (Audacity Team) wrote: >> Hi Leland >> When you removed Screenshot Tools from #ifdef __WXDEBUG__ in Menus.cpp >> rev.1.463 >> so they could be in release builds as well, you put Run Benchmark inside >> that #ifdef >> instead. I know the Benchmark isn't ideal but it's referenced in the >> Manual so I assumed >> it was going into 1.4? >> >> These are the relevant lines in the current Menus.cpp: >> >> 966 if( !mCleanSpeechMode ) >> 967 { >> 968 c->AddSeparator(); >> 969 c->AddItem(wxT("Screenshot"), _("&Screenshot Tools..."), >> FN(OnScreenshot)); >> 970 #ifdef __WXDEBUG__ >> 971 c->AddSeparator(); >> 972 c->AddItem(wxT("Benchmark"), _("&Run Benchmark..."), >> FN(OnBenchmark)); >> 973 #endif >> 974 c->AddSeparator(); >> 975 c->AddItem(wxT("DeviceInfo"), _("&Audio Device Info..."), >> FN(OnAudioDeviceInfo)); > > > Could we have a decision on this please. Is "Run Benchmark" in Debug only > (-1 here); and if removing it > from Beta was a mistake, is it in 2.0? > I always thought Run Benchmark was intended to be development only. What use is it to the user? And I believe there's been discussions about it being "incorrect" anyway. But, makes no real difference to me. Leland |
From: Gale A. <ga...@au...> - 2009-05-29 22:38:15
|
| From Leland <le...@au...> | Thu, 28 May 2009 19:22:22 -0500 | Subject: [Audacity-devel] Run Benchmark removed from Release builds > Gale (Audacity Team) wrote: > > Gale (Audacity Team) wrote: > >> Hi Leland > >> When you removed Screenshot Tools from #ifdef __WXDEBUG__ in Menus.cpp > >> rev.1.463 > >> so they could be in release builds as well, you put Run Benchmark inside > >> that #ifdef > >> instead. I know the Benchmark isn't ideal but it's referenced in the > >> Manual so I assumed > >> it was going into 1.4? > >> > >> These are the relevant lines in the current Menus.cpp: > >> > >> 966 if( !mCleanSpeechMode ) > >> 967 { > >> 968 c->AddSeparator(); > >> 969 c->AddItem(wxT("Screenshot"), _("&Screenshot Tools..."), > >> FN(OnScreenshot)); > >> 970 #ifdef __WXDEBUG__ > >> 971 c->AddSeparator(); > >> 972 c->AddItem(wxT("Benchmark"), _("&Run Benchmark..."), > >> FN(OnBenchmark)); > >> 973 #endif > >> 974 c->AddSeparator(); > >> 975 c->AddItem(wxT("DeviceInfo"), _("&Audio Device Info..."), > >> FN(OnAudioDeviceInfo)); > > > > > > Could we have a decision on this please. Is "Run Benchmark" in Debug only > > (-1 here); and if removing it > > from Beta was a mistake, is it in 2.0? > > > I always thought Run Benchmark was intended to be development only. > What use is it to the user? And I believe there's been discussions > about it being "incorrect" anyway. I mentioned it because a couple of users noticed it even before I did. I thought doubts had been cast on Benchmark in -devel list but I could not find anything when I searched Nabble (except for my own comment that it seemed to overestimate the number of tracks that could be played simultaneously). Perhaps it does not really predict that? Anyway it tells me I can play 33 tracks at once at 44/16, and yes in 1.3.8 if I have 33 various tracks of 30 seconds each, they play and respond quite nicely. In 1.3.5 it is very uncomfortable to do that (from pressing Play to hearing audio is often 10 seconds, and 5 seconds plus to get a menu response). I've seen complaints on Linux and Mac that even after our changes to improve multi-track response, playback will garble at the start of a separate clip in the middle of a track. But I've just tried that on 1.3.8 in Windows XP with 6 of the 33 tracks having clips in the middle and do not get that problem at all. So I'll leave the experts to decide if Benchmark should be in Beta, but with reservations I think it could be (if so, tell me what to say in the Manual). Gale |
From: Leland <le...@au...> - 2009-05-29 23:04:50
|
Quoting Gale Andrews <ga...@au...>: > > So I'll leave the experts to decide if Benchmark should be in Beta, but > with reservations I think it could be (if so, tell me what to say in the > Manual). > Oh, I get what you were asking now!!! Yes, it SHOULD be in Betas. It always has been and I was wrong to ifdef() it like that. Geez...I must've been even more braindead that day than I normally am!!! I will correct when I get home. Leland |