Menu ▾ ▴

#107 Missing ifndef guards

Release 3.0
closed-fixed
nobody
Assimp lib (91)
5
2012-12-20
2012-12-15
Frederik Aalund
No

As per the discussion in: https://sourceforge.net/mailarchive/forum.php?thread_name=CAA%3DpTTRQw2LqCtwFs%3DVcL%2BRoxyEFoYEeu3pkv_hKi1RcW9R7uA%40mail.gmail.com&forum_name=assimp-discussions

When you define the flag ASSIMP_BUILD_NO_LWS_IMPORTER then the contents of LWSLoader.cpp is still being compiled. It needs to be wrapped in "#ifndef ASSIMP_BUILD_NO_LWS_IMPORTER [...file contents...] #endif" just as you do in ImporterRegistry.cpp. Otherwise the compiler will still try to build the source even with the flag is defined. I guess this goes for all the other ASSIMP_BUILD_NO_*_IMPORTER flags.

Discussion

  • Thomas Ziegenhagen

    Thomas Ziegenhagen - 2012-12-20
    • status: open --> closed-fixed
     

  • Thomas Ziegenhagen

    Thomas Ziegenhagen - 2012-12-20

    Thanks for the report. I checked all importers and corrected a few where the preprocessor flags where missing.