Re: [Arianne-devel] Piece code review

[MIGUEL A. B. L. <mb...@fe...>]

> > /** This method split a string in several strings
> > based on the delimiter. */
> > vector<string> Split(const string& orig, const
> > string delimiter = " ")
> >   {
> >   //TODO: There must be a better place for this
> > function.
> >   int x = orig.find(delimiter);
> >   if ( x == -1 )
> >     {
> >     vector<string> retval;
> >     retval.push_back(orig);
> > 
> > This was commented, but shouldn't it return the
> > original string if there is no 
> > delimiters?
> 
> Yes I agree, would you please make the change?

Sure, I did when I saw it.
Just wanted to be sure of it was the right behaviour.

 
> > Object::ObjectNotFoundException(__FILE_AND_LINE__);
> =========
> 
> That's all I got, could you re-send (at least to me
> personally) so that I could see the rest.
> 
> Also, today I will start my code review of the
> ScriptRunner and the Python stuff.

ok, but the rest of the code is just the same thing...
I have placed the updated one on SF, you can use CVSweb to see it if you don't 
have access to CVS.