[Arianne-bugs] [ arianne-Patches-3167555 ] friend achievement category

[SourceForge.net <no...@so...>]

Patches item #3167555, was opened at 2011-01-29 12:40
Message generated for change (Settings changed) made by kymara
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=301111&aid=3167555&group_id=1111

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Katie Russell (kymara)
>Assigned to: Katie Russell (kymara)
Summary: friend achievement category

Initial Comment:
add friend achievement category which is about being friendly, i.e. no pvp for a long time, helping all the children, finding all the lost people. moved susi achievement into the more general one of helping children. make sure quest related achievements get notified on finishing quest, even if not in pure quest category

still need to add the no-pvp and good karma achievements to this. not tested fully yet, but cvs is down and want to save code

----------------------------------------------------------------------

Comment By: Katie Russell (kymara)
Date: 2011-02-10 19:35

Message:
Thanks for the patch.
It has been applied to cvs trunk.

----------------------------------------------------------------------

Comment By: Katie Russell (kymara)
Date: 2011-01-29 21:38

Message:
added an update to the patch (use them  both, in order) : Fix quest
completed checks on quests which didn't have canonical completion. Added
karma achievement

----------------------------------------------------------------------

Comment By: Katie Russell (kymara)
Date: 2011-01-29 19:10

Message:
or if we could have an instance of the quest it's the isCompleted method.
checking for the children quests now

----------------------------------------------------------------------

Comment By: Katie Russell (kymara)
Date: 2011-01-29 18:47

Message:
the condition for the seven cherubs was wrong as it doesnt get set to
done:

// Meet Angels (any of the cherubs)
														new ChatCondition() {
															public boolean fire(final Player player, final Sentence
sentence, final Entity entity) {
																if (!player.hasQuest("seven_cherubs")) {
																	return false;
																}
																final String npcDoneText =
player.getQuest("seven_cherubs");
																final String[] done = npcDoneText.split(";");
																final int left = 7 - done.length;
																return left < 0;
															}
														})));

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=301111&aid=3167555&group_id=1111