From: SourceForge.net <no...@so...> - 2009-05-05 16:59:35
|
Bugs item #2787240, was opened at 2009-05-05 13:30 Message generated for change (Settings changed) made by astridemma You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=2787240&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Code Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Katie (kymara) Assigned to: Nobody/Anonymous (nobody) Summary: cant refer to tests from stendhaltools Initial Comment: If you refer to something in tests from something in src/games/stendhal/tools/ then you create a circular dependency problem : ant compile_stendhaltools would require tests to have been compiles but ant compile_tests requires ant compile_stendhaltools already. Till the problem is fixed, perhaps it is wise to not refer to tests from inside tools? ---------------------------------------------------------------------- Comment By: Astrid Sawatzky (astridemma) Date: 2009-05-05 16:56 Message: mock is only there because the real objects are too dependant on each other. It is a way to have tests (!) on objects that could not be tested otherwise. IMHO it is not wise to have tools rely on stuff that should not be there in the first. ---------------------------------------------------------------------- Comment By: Katie (kymara) Date: 2009-05-05 16:12 Message: http://arianne.cvs.sourceforge.net/viewvc/arianne/stendhal/src/games/stendhal/tools/BalanceRPGame.java?r1=1.53&r2=1.54 how it was fixed previously. ---------------------------------------------------------------------- Comment By: MadMetzger (madmetzger) Date: 2009-05-05 16:05 Message: Yes, it is wise not to refer to tests. My suggestion was to move the mock classes to the tools, when this problem first arose. ATM I do not see another solution. And I think it would be okay to move them, because the mocks are used as tools for the build and test process. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=2787240&group_id=1111 |