From: SourceForge.net <no...@so...> - 2008-01-27 14:48:36
|
Bugs item #1866706, was opened at 2008-01-08 12:02 Message generated for change (Comment added) made by martinfuchs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1866706&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: tigertoes (tigertoes) Assigned to: Martin Fuchs (martinfuchs) Summary: Sato dialog out of sequence Initial Comment: [10:17] <tigertoes> hi [10:17] <Sato> Greetings! How may I help you? [10:17] <tigertoes> help [10:17] <Sato> I purchase sheep, at what I think is a fairly reasonable price. Just say if you want to sell sheep, and I will set up a deal! [10:17] <tigertoes> sell sheep [10:17] <Sato> 1 sheep is worth 0. Do you want to sell it? [10:17] <tigertoes> yes [10:17] <Sato> You don't have any sheep, tigertoes! What are you trying to pull? test for whether player has a sheep should be prior to telling what his sheep is worth ---------------------------------------------------------------------- Comment By: Martin Fuchs (martinfuchs) Date: 2008-01-27 15:48 Message: Logged In: YES user_id=1534223 Originator: NO OK, thanks for the error report. Problem is now fixed in CVS. ---------------------------------------------------------------------- Comment By: Katie (kymara) Date: 2008-01-17 14:33 Message: Logged In: YES user_id=1560922 Originator: NO So i've looked at the code i might as well share my insight (or lack thereof). In src/games/stendhal/maps/semos/city/SheepbuyerNPC.java only transactAgreedDeal is overridden from the seller behaviour. this means that as tig found he sounds like a normal seller (ie. his responses to sell sheep etc) until the deal is 'agreed' and he goes through to 'transactAgreedDeal' -- so i think the start of the deal needs to be overridden too so that he can check sheep weight and existence of sheep sooner. ---------------------------------------------------------------------- Comment By: tigertoes (tigertoes) Date: 2008-01-08 12:04 Message: Logged In: YES user_id=1974612 Originator: YES sorry.. hit reload to look at new entries .. delete this ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1866706&group_id=1111 |