#5822 KillEnemyArmy quest bug

[yoriy]

make that GM command:
/alterquest <player name=""> kill_enemy_army "start;madaram;madaram healer,0,0,114,0,madaram buster blader,0,0,11,0,madaram stalker,0,0,26,4,madaram queen,0,0,27,0,madaram axeman,0,0,44,0,madaram trooper,0,0,37,1,madaram peasant,0,0,70,0,madaram soldier,0,0,19,0,madaram cavalry,0,0,40,1,kasarkutominubat,0,0,14,1,madaram hero,0,0,43,0"

and Despoth will not respond at "quest" trigger of that player anymore

[Anonymous]

java.lang.ArrayIndexOutOfBoundsException: 58
at java.util.Arrays$ArrayList.get(Arrays.java:2866)
at games.stendhal.server.maps.quests.KillEnemyArmy.getKilledCreaturesNumber(KillEnemyArmy.java:265)
at games.stendhal.server.maps.quests.KillEnemyArmy.access$000(KillEnemyArmy.java:77)
at games.stendhal.server.maps.quests.KillEnemyArmy$ExplainAction.fire(KillEnemyArmy.java:361)
at games.stendhal.server.entity.npc.fsm.Engine.executeTransition(Engine.java:600)
at games.stendhal.server.entity.npc.fsm.Engine.matchTransition(Engine.java:565)
at games.stendhal.server.entity.npc.fsm.Engine.step(Engine.java:439)
at games.stendhal.server.entity.npc.fsm.Engine.step(Engine.java:421)
at games.stendhal.server.entity.npc.SpeakerNPC.tell(SpeakerNPC.java:714)
at games.stendhal.server.entity.npc.SpeakerNPC.preLogic(SpeakerNPC.java:411)
at games.stendhal.server.core.engine.StendhalRPRuleProcessor.executeNPCsPreLogic(StendhalRPRuleProcessor.java:343)
at games.stendhal.server.core.engine.StendhalRPRuleProcessor.beginTurn(StendhalRPRuleProcessor.java:300)
at marauroa.server.game.rp.RPServerManager.run(RPServerManager.java:601)

[yoriy]

the reason why kills quests are hardly extensible: if adding new elements to quest, idle players have problems at next chatting. I hope i know the way to fix that, using their !kills slot contents.

[yoriy]

fixed now, waiting for related reports.

[Hendrik Brummermann]

I like to propose the attachted alternative solution. I think it fixes the issue, although I know too little about the world to test it well. It works without forcing the player to restart the quest by telling them about a bug.

[yoriy]

There are two aspects of a problem.
At first, this patch will fix an issue, but player will lose his kills of newly added to his quest creatures. It is not really good, at least unfair - player will never know why his kills wasnt counted.
At second, player will get that message only if his quest slot really damaged and cannot be fixed automatically. It means unpossible quest states, like if part of his record was totally lost by some reasons (include GM interventions). I added this only for complete npc conversations, and there may be other solutions, like throwing exceptions for future investigations by server admins.