Menu

#247 Check the simulations in the bottom most panel for laback2023

1.7
accepted
bug (35)
2024-09-27
2023-05-20
No

This is a follow up of ticket #207, about the integration of the precursor model by Laback 2023.

The simulations shown in the lowest-most panels should use the model ashida2016, but when using that model (ANmode=1, instead of 3), the results do not seem to agree with the figure from the paper.

Discussion

  • Piotr Majdak

    Piotr Majdak - 2023-05-25
    • Milestone: later --> 1.4.0
     
  • Piotr Majdak

    Piotr Majdak - 2023-05-30
    • Milestone: 1.4.0 --> 1.4.1
     
  • Piotr Majdak

    Piotr Majdak - 2023-06-16
    • status: open --> accepted
    • Milestone: 1.4.1 --> 1.5.0
     
  • Piotr Majdak

    Piotr Majdak - 2023-06-30

    Could you check if the the rows in the figure calculate:

    • Row 1: smalt model with MOCR activated
    • Row 2: smalt model without the MOCR
    • Row 3: zilany model without the Ashida LSO stage
    • Row 4: zilany model with the Ashida LSO stage activated
      It would be good if the model laback2023 would have these option promimently available, with all other parameters hidden by defaults. Would that be feasible?

    Also: The three most-left columns should also represent the three spontaneous rates (SR) and the most-right column should be the weighted average of the three most-left columns. Currently, the average panel in the bottom row does not seem to match the "average" of the other three panels. Could you check?

     
  • Piotr Majdak

    Piotr Majdak - 2023-07-28

    The last row is really wrong, but also the other rows are not identical with the paper's Fig. 5. I talked with Bernhard and he has some ideas for the potential reasons. In order to being able to better debug the code, I have refactored exp_laback2023: added caching and splitted the calculations of the smalt- and zilany-based models. Now, fig5ab and figcd can be calculated again separately. Bernhard is on vacations now, so let's move this issue to 1.6.0...

     
  • Piotr Majdak

    Piotr Majdak - 2023-07-28
    • Milestone: 1.5.0 --> 1.6.0
     
  • Piotr Majdak

    Piotr Majdak - 2023-07-31
    • labels: --> bug
    • Milestone: 1.6.0 --> 1.5.1
     
  • Piotr Majdak

    Piotr Majdak - 2024-08-19
    • Milestone: --> 1.6.0
     
  • Piotr Majdak

    Piotr Majdak - 2024-09-27
    • Milestone: 1.6.0 --> 1.7
     

Log in to post a comment.

MongoDB Logo MongoDB