Menu
▾
▴
#1630 [G2] Double-clicking activate for a new user causes errors
I have my gallery set up so that a user registers, and
I confirm them. I clicked activate twice, I got a page
with a few mkdir errors, then when I tried to display
the page with the new user's album(s) I got the
ERROR_MISSING_OBJECT error when trying to display the
page with that person's albums.
A workaround was to click delete album on a live album,
then select the album to delete. Or to paste the
album's name into the url bar, and click delete album
on the left hand side of the screen.
Logged In: YES
user_id=1376801
http://gallery.menalto.com/node/39852#comment-148667
Logged In: YES
user_id=942712
confirmed. i could reproduce this bug easily.
it's probably a small bug in the admin controller of the
register module.
Logged In: YES
user_id=42211
I tried and failed to reproduce this, both on mysql and
postgres. Andy, was there anything special you did? To
make sure it was actually doing two requests in parallel I
middle-clicked the activate button so that I could see the
two requests go. The first one worked fine. The second one
lead to this error:
Error (ERROR_MISSING_OBJECT) : Missing object for 17
* in
modules/core/classes/GalleryStorage/GalleryStorageExtras.class
at line 1776 (gallerycoreapi::error)
* in
modules/core/classes/GalleryStorage/GalleryStorageExtras.class
at line 109 (gallerystorageextras::_identifyentities)
* in modules/core/classes/GalleryStorage.class at line
266 (gallerystorageextras::loadentities)
* in
modules/core/classes/helpers/GalleryEntityHelper_simple.class
at line 82 (mysqlstorage::loadentities)
* in modules/core/classes/GalleryCoreApi.class at line
2380 (galleryentityhelper_simple::loadentitiesbyid)
* in modules/register/AdminSelfRegistration.inc at line
62 (gallerycoreapi::loadentitiesbyid)
* in main.php at line 198
(adminselfregistrationcontroller::handlerequest)
* in main.php at line 87
* in main.php at line 80
That seems normal to me. I had it set to create the user
album immediately, and the album was created just fine. I
logged in as the user without difficulties. I deleted the
user's album without difficulties.
What am I missing?
Logged In: YES
user_id=942712
What I get:
- ERROR_MISSING_OBJECT in the admin page when clicking
multiple times.
Should we do something about this? Maybe.
But on a larger / more general scale:
E.g. a Javascript thing that ignores double clicks /
disables links as soon as one is clicked since the webserver
handles the request anyway / you can't stop it.
- I do NOT get any other error. e.g. if i visit the user
album created for this new user, it works fine. No error.
Logged In: YES
user_id=42211
Fixed the ERROR_MISSING_OBJECT issue by ignoring bad ids in
rev 13807. We can deal with the deeper "how do we stop
double clicks" problem at some later date. Can't reproduce
the data corruption error, so I'm closing this bug. Please
reopen it if you figure out how to repro the data corruption.