Enhance ADempiere to read ADEMPIERE_HOME from web.xml
This will enable ADempiere to start as regular web application without the need to pass environment variable or System property
For documentation purposes: the web.xml files were edited with comments - so in adempiere out of the box the effect is null - you need to edit web.xml within webui and webstore and recreate the war files to make it work.
NOTE: A better approach would be to replace ADEMPIERE_HOME variable in a webTemplate.xml.
I would like a second opinion from Heng Sin on these commit as it's about zkwebui.
Regards,
Carlos Ruiz
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It certainly doesn't break anything but not very useful for me ( I don't
know whether Trifon have different use case but that's my personal
opinion)
* Not needed when running on a deploy instance as the ADEMPEIRE_HOME
environment variable is already setup.
* When running from eclipse, it is easy to do using system variable (-D)
and it wouldn't mark my web.xml as dirty. Also, I frequently run the same
instance against multiple home - very easy using multiple run
configuration and -D variables.
Regards,
Low
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Here is the stack trace:
Exception in thread "main" java.lang.NullPointerException
at org.compiere.util.Ini.getAdempiereHome(Ini.java:764)
at org.compiere.util.Ini.findAdempiereHome(Ini.java:789)
at org.compiere.util.CLogFile.<init>(CLogFile.java:70)
at org.compiere.util.CLogFile.get(CLogFile.java:46)
at org.compiere.util.CLogMgt.initialize(CLogMgt.java:157)
at org.compiere.util.Ini.setClient(Ini.java:717)
at org.compiere.Adempiere.startup(Adempiere.java:479)
at org.compiere.Adempiere.startupEnvironment(Adempiere.java:523)
at org.adempiere.util.GenerateModel.main(GenerateModel.java:70)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Committed with SVN
Revision: 11821
http://adempiere.svn.sourceforge.net/adempiere/?rev=11821&view=rev
Revision: 11822
http://adempiere.svn.sourceforge.net/adempiere/?rev=11822&view=rev
Solution is backward compatible so by default ADempiere search for System property
Trifon
Hi, as this changes is useful just for web apps - I added a validation for that in revision 11838.
http://adempiere.svn.sourceforge.net/adempiere/?rev=11838&view=rev
For documentation purposes: the web.xml files were edited with comments - so in adempiere out of the box the effect is null - you need to edit web.xml within webui and webstore and recreate the war files to make it work.
NOTE: A better approach would be to replace ADEMPIERE_HOME variable in a webTemplate.xml.
I would like a second opinion from Heng Sin on these commit as it's about zkwebui.
Regards,
Carlos Ruiz
Hi,
It certainly doesn't break anything but not very useful for me ( I don't
know whether Trifon have different use case but that's my personal
opinion)
* Not needed when running on a deploy instance as the ADEMPEIRE_HOME
environment variable is already setup.
* When running from eclipse, it is easy to do using system variable (-D)
and it wouldn't mark my web.xml as dirty. Also, I frequently run the same
instance against multiple home - very easy using multiple run
configuration and -D variables.
Regards,
Low
@ HengSin,
Use case is simple.
Deployer do not have control over Server start environment.
Regards,
Trifon
integrated to release with revision 11865
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
Revision: 12153
http://adempiere.svn.sourceforge.net/adempiere/?rev=12153&view=rev
Author: teo_sarca
Date: 2010-04-26 19:20:10 +0000 (Mon, 26 Apr 2010)
Log Message:
-----------
Fix NPE when running GenerateModel
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2977050
Modified Paths:
--------------
trunk/base/src/org/compiere/util/Ini.java
Here is the stack trace:
Exception in thread "main" java.lang.NullPointerException
at org.compiere.util.Ini.getAdempiereHome(Ini.java:764)
at org.compiere.util.Ini.findAdempiereHome(Ini.java:789)
at org.compiere.util.CLogFile.<init>(CLogFile.java:70)
at org.compiere.util.CLogFile.get(CLogFile.java:46)
at org.compiere.util.CLogMgt.initialize(CLogMgt.java:157)
at org.compiere.util.Ini.setClient(Ini.java:717)
at org.compiere.Adempiere.startup(Adempiere.java:479)
at org.compiere.Adempiere.startupEnvironment(Adempiere.java:523)
at org.adempiere.util.GenerateModel.main(GenerateModel.java:70)
integrated fix from Teo to release with revision 12243
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).