Menu ▾ ▴

#2278 Problems in Requisition window

Core
open
nobody
Requisition (16)
9
2009-12-29
2009-12-29
Carlos Ruiz
No

Create PO for Requisition 101

Now open Requisition window and search/navigate to requisition 101
Move to the second tab (Requisition Line) it must be read-only because the requisition is processed
Move to the third tab (Purchase Orders) <--- first problem, you can edit the description, this is a READ-ONLY tab, it must not allow edition
Now move again to second tab <-- second problem, you can edit the record, the requisition is complete, but you can edit it because the order you navigated it's not

Not researched, but probably this problem could be solved dropping the "Processed" field on the third tab. Or adding a Processed field to requisition line.

Also, this problem could exist in other windows where a detail record is trusting on the "Processed" flag of the header record.

Regards,

Carlos Ruiz

Discussion

  • Carlos Ruiz

    Carlos Ruiz - 2010-01-04

    Committed revision 11222
    http://adempiere.svn.sourceforge.net/adempiere/?rev=11222&view=rev
    Fix dictionary to avoid making the second tab read-write after navigating to third tab.

    There are other potential tabs with this problem:
    window tab
    ------------------ ----------------
    Payroll Definition Payroll Concepts
    Project Task
    Invoice (Vendor) Landed Costs
    Requisition Requisition Line
    Project Phase

    discovered with the query:

    select distinct w.name, t2.name
    from ad_window w, ad_tab t1, ad_tab t2, ad_tab t3
    where w.ad_window_id=t1.ad_window_id
    and w.ad_window_id=t2.ad_window_id
    and w.ad_window_id=t3.ad_window_id
    and t2.seqno>t1.seqno
    and t3.seqno>t2.seqno
    and t2.isreadonly='N'
    and exists (select 1 from ad_field f where f.ad_tab_id=t1.ad_tab_id and f.name='Processed')
    and not exists (select 1 from ad_field f where f.ad_tab_id=t2.ad_tab_id and f.name='Processed')
    and exists (select 1 from ad_field f where f.ad_tab_id=t3.ad_tab_id and f.name='Processed')

    Just solved for the requisition tab.

    Pending to solve the problem of a read-only tab allowing changes on always-updatable field.

    Regards,

    Carlos Ruiz

     

  • Carlos Ruiz

    Carlos Ruiz - 2010-03-25

    The second part of this issue is covered on this bug report:
    [2684504] - Tab read only logic doesn't make fields RO
    So, maybe we can leave this open just for the first part.

    Regards,

    Carlos Ruiz

     

Log in to post a comment.