WinMerge / Bugs / #1514 "Copy/Move to" confirmation dialog shows wrong "To" path

#1514 "Copy/Move to" confirmation dialog shows wrong "To" path

Milestone: Trunk

Status: closed-fixed

Owner: Kimmo Varis

Labels: GUI (515)

Priority: 5

Updated: 2007-06-26

Created: 2007-06-19

Creator: Tim Gerundt

Private: No

If I use "Copy to" or "Move to" from the folder compare popup menu AND copy a full path in path box from the folder select dialog, the confirmation dialog shows a wrong "To" path.

But it happens only, if you copy a path to the box and not if click the path in the tree view!

Greetings,
Tim

Discussion

Tim Gerundt - 2007-06-19

screenshot from German folder select dialog

select_folder_dialog.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-20

Logged In: YES
user_id=631874
Originator: NO

Does WinMerge copy/move files to correct folder? Or does it just show wrong path?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Gerundt - 2007-06-20

Logged In: YES
user_id=652377
Originator: YES

No, it just show the wrong path. WinMerge copy/move the files to correct folder.

And I just noticed, that the bug only happens, if you want to copy/move more than 1 items!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-20

Logged In: YES
user_id=631874
Originator: NO

Thanks for information. I took a quick look at the code, but just don't understand how this is happening. SelectFolder() returns just one path. Where that wrong path could be coming from?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Gerundt - 2007-06-20

Logged In: YES
user_id=652377
Originator: YES

> Where that wrong path could be coming from?

WinMerge seems to show in this case always the *right* path in "From" _and_ "To". Even when I copy/move from left to somewhere else...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-26

Logged In: YES
user_id=631874
Originator: NO

Ok, can you write steps how to reproduce this? As this doesn't seem so obvious after all (need to copy/paste paths etc).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-26

Logged In: YES
user_id=631874
Originator: NO

Ok, reproducing was easy after all.

I'm attaching a patch to fix the bug.

File Added: CopyToDestPath.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-26

assigned_to: nobody --> kimmov
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-26

Original and altered files

CopyToDestPath.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tim Gerundt - 2007-06-26

Logged In: YES
user_id=652377
Originator: YES

Thanks, the patch works! :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-26

Logged In: YES
user_id=631874
Originator: NO

Thanks for testing the patch!

Patch committed to SVN trunk.
Completed: At revision: 4350

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2007-06-26

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.