Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#1514 "Copy/Move to" confirmation dialog shows wrong "To" path

Trunk
closed-fixed
GUI (515)
5
2007-06-26
2007-06-19
Tim Gerundt
No

If I use "Copy to" or "Move to" from the folder compare popup menu AND copy a full path in path box from the folder select dialog, the confirmation dialog shows a wrong "To" path.

But it happens only, if you copy a path to the box and not if click the path in the tree view!

Greetings,
Tim

Discussion

  • Tim Gerundt

    Tim Gerundt - 2007-06-19

    screenshot from German folder select dialog

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-20

    Logged In: YES
    user_id=631874
    Originator: NO

    Does WinMerge copy/move files to correct folder? Or does it just show wrong path?

     
  • Tim Gerundt

    Tim Gerundt - 2007-06-20

    Logged In: YES
    user_id=652377
    Originator: YES

    No, it just show the wrong path. WinMerge copy/move the files to correct folder.

    And I just noticed, that the bug only happens, if you want to copy/move more than 1 items!

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-20

    Logged In: YES
    user_id=631874
    Originator: NO

    Thanks for information. I took a quick look at the code, but just don't understand how this is happening. SelectFolder() returns just one path. Where that wrong path could be coming from?

     
  • Tim Gerundt

    Tim Gerundt - 2007-06-20

    Logged In: YES
    user_id=652377
    Originator: YES

    > Where that wrong path could be coming from?

    WinMerge seems to show in this case always the *right* path in "From" _and_ "To". Even when I copy/move from left to somewhere else...

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-26

    Logged In: YES
    user_id=631874
    Originator: NO

    Ok, can you write steps how to reproduce this? As this doesn't seem so obvious after all (need to copy/paste paths etc).

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-26

    Logged In: YES
    user_id=631874
    Originator: NO

    Ok, reproducing was easy after all.

    I'm attaching a patch to fix the bug.

    File Added: CopyToDestPath.zip

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-26
    • assigned_to: nobody --> kimmov
     
  • Kimmo Varis

    Kimmo Varis - 2007-06-26

    Original and altered files

     
  • Tim Gerundt

    Tim Gerundt - 2007-06-26

    Logged In: YES
    user_id=652377
    Originator: YES

    Thanks, the patch works! :)

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-26

    Logged In: YES
    user_id=631874
    Originator: NO

    Thanks for testing the patch!

    Patch committed to SVN trunk.
    Completed: At revision: 4350

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-26
    • status: open --> closed-fixed
     

Log in to post a comment.