Menu

#954 4.0b8 View GEDCOM record

closed-fixed
None
2
2006-06-15
2006-05-25
No

Logged as admin.

On any family page :
Options for family > Other > View GEDCOM record
returns a privacy error message.

Fixed :
gedrecord.php
family_class.php

Discussion

  • Christophe B.

    Christophe B. - 2006-05-25
    • status: open --> open-fixed
     
  • KosherJava

    KosherJava - 2006-05-25

    Logged In: YES
    user_id=634811

    Same problem exists on the source page.

     
  • KosherJava

    KosherJava - 2006-05-25
    • summary: 4.0b8 Family : View GEDCOM record --> 4.0b8 Family and Source : View GEDCOM record
     
  • Christophe B.

    Christophe B. - 2006-05-25

    Logged In: YES
    user_id=1006499

    Fixed for source page :
    gedrecord.php
    source_class.php

    And same problem exists on the REPO page.
    Not yet fixed...

     
  • Christophe B.

    Christophe B. - 2006-05-25
    • summary: 4.0b8 Family and Source : View GEDCOM record --> 4.0b8 View GEDCOM record
     
  • KosherJava

    KosherJava - 2006-05-25

    Logged In: YES
    user_id=634811

    Maybe this should be moved to the base GedcomRecord object
    so there will not have to be checks for each type.

     
  • KosherJava

    KosherJava - 2006-05-25

    Logged In: YES
    user_id=634811

    Actually I just had a look at SVN and CVS it looks like John
    has already implementid the use of the base class to fix this.

     
  • John Finlay

    John Finlay - 2006-05-25

    Logged In: YES
    user_id=300048

    I tried to post this earlier, but SF was down and I had to
    go to class :P

    I have applied the factory pattern to the main GedcomRecord
    class so that we can get an instance of any object type
    without knowing before hand what type of object it is.

    So we can ask for
    $obj = GedcomRecord::getInstance("R1");

    Which will return a generic GedcomRecord object for a
    repository but will return a Person object if we ask for a
    person.

    If you know what type of record you want then you should use
    the getInstance method of that class as it will be faster.
    For example if you know you want a person you should ask for
    it using the Person::getInstance() instead of the
    GedcomRecord::getInstance() as Person::getInstance() will be
    faster. But if you don't know or don't care what type it
    is, as in this case then we can use the generic
    GedcomRecord::getInstance()

    --John

     
  • Patrik Hansson

    Patrik Hansson - 2006-06-15
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.