Probably compiled savebuff.cpp without defining LEGACY_SAVEBUFF?
I also stumbled on this when wanting to use this module because it is so much nicer than the buffextras module in my opinion, because it allows me to use a script and parse it's output in my client and it integrates so nice because of that, it's like I never disconnected from IRC/ZNC at all when it plays back the buffer! :)
I even also added TOPIC-changes support to it, so it plays that back too.
Because of the changes (topic support and removed the ifdef for LEGACY_SAVEBUFF), I just renamed the module to savecompbuff.cpp (Save Complete Buffer :P)
Works very nicely and output looks better than when using buffextras.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It seems my previous comment is maybe a little out of place here (I just noticed this is for patches), anyway to be on topic again: an option to turn on/off output of joins/parts/etc would maybe be nice but because of the current define it's maybe pointless, unless that define is removed again and the code thus re-enabled by default... (in which case it might render buffextras a little useless for those that want to parse the output themselves instead of the "friendly" pre-programmed playback messages that buffextras has)
In your patch, please consider adding topic playback to it aswell, this is what I'm using:
+ virtual EModRet OnTopic(CNick& cNick, CChan& cChannel, CString& sTopic) {
+ AddBuffer(cChannel, SpoofChanMsg(cChannel.GetName(), cNick.GetNickMask() + " TOPIC " + sTopic));
+ return CONTINUE;
+ }
If wanted I can post my derivative of the savebuff.cpp module? But of course it won't have the option that this patch thread is all about...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry, no idea how I missed this for so long.
Also no idea what you are saying. Did you perhaps forgot the patch?
Apparently so. Not sure what I did with it, since its not in use now, but I do remember making it. I'll post it again when I find it.
Probably compiled savebuff.cpp without defining LEGACY_SAVEBUFF?
I also stumbled on this when wanting to use this module because it is so much nicer than the buffextras module in my opinion, because it allows me to use a script and parse it's output in my client and it integrates so nice because of that, it's like I never disconnected from IRC/ZNC at all when it plays back the buffer! :)
I even also added TOPIC-changes support to it, so it plays that back too.
Because of the changes (topic support and removed the ifdef for LEGACY_SAVEBUFF), I just renamed the module to savecompbuff.cpp (Save Complete Buffer :P)
Works very nicely and output looks better than when using buffextras.
It seems my previous comment is maybe a little out of place here (I just noticed this is for patches), anyway to be on topic again: an option to turn on/off output of joins/parts/etc would maybe be nice but because of the current define it's maybe pointless, unless that define is removed again and the code thus re-enabled by default... (in which case it might render buffextras a little useless for those that want to parse the output themselves instead of the "friendly" pre-programmed playback messages that buffextras has)
In your patch, please consider adding topic playback to it aswell, this is what I'm using:
+ virtual EModRet OnTopic(CNick& cNick, CChan& cChannel, CString& sTopic) {
+ AddBuffer(cChannel, SpoofChanMsg(cChannel.GetName(), cNick.GetNickMask() + " TOPIC " + sTopic));
+ return CONTINUE;
+ }
If wanted I can post my derivative of the savebuff.cpp module? But of course it won't have the option that this patch thread is all about...
No patch attaached, nothing to look at.