[zd1211-devs] feedback on ./Makefile
Status: Beta
Brought to you by:
mayne
From: William P. <ope...@ya...> - 2005-12-28 23:24:06
|
While making Slackware package, I noticed that ./Makefile has install: all mkdir -p $(MODPATH)/net # mkdir -p /etc/zd1211 cp $(MODULE) $(MODPATH)/net depmod -a <--- 1 #for apdbg gcc -o apdbg apdbg.c chmod +x apdbg <--- 2 cp ./apdbg /sbin/apdbg <--- 2 1. When a normal user installs with 'sudo make install', it cannot find 'depmod', because /sbin is not in the PATH. So, it should be full path, ie. /sbin/depmod -a 2. Since this is local installation, a more logical place for the binary is '/usr/local/sbin/'. So, one can replace two lines with install -s ./apdbg /usr/local/sbin/ Just my feedback... -- William Park <ope...@ya...>, Toronto, Canada ThinFlash: Linux thin-client on USB key (flash) drive http://home.eol.ca/~parkw/thinflash.html BashDiff: Super Bash shell http://freshmeat.net/projects/bashdiff/ |