Re: [XonX-Users] threaded X11 libs on Darwin
Brought to you by:
torrey
From: Torrey L. <to...@mr...> - 2001-12-30 17:03:03
|
Looks good. This seems reasonable, but its too late to incorporate a potentially risky change like this before the XFree86 4.2 release in a week or two. There are possibly some issues with the fact that some of Darwin's C library is not thread safe. I suppose we'll get some good testing from Fink users. In any case, I'll look at putting this in after the 4.2 release. Let me know if you get any good or bad feedback from the Fink folk. --Torrey ---- Jeff Whitaker <js...@cd...> wrote: > Torrey: To enable threads I added > > # define ThreadedX YES > # define HasThreadSafeAPI YES > # define SystemMTDefines -D_REENTRANT > # define MTSafeAPIDefines -DXUSE_MTSAFE_API - DXNO_MTSAFE_PWDAPI > > to darwin.cf and applied the following patch to Xos_r.h > > --- xc/include/Xos_r.h.orig Sat Dec 29 18:22:34 2001 > +++ xc/include/Xos_r.h Sat Dec 29 18:25:12 2001 > @@ -248,8 +248,8 @@ > * fields. > */ > > -#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__OpenBSD__) > -__inline__ void _Xpw_copyPasswd(_Xgetpwparams p) > +#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__OpenBSD__) > || defi > ned(__APPLE__) > +__inline__ static void _Xpw_copyPasswd (_Xgetpwparams p) > { > memcpy(&(p).pws, (p).pwp, sizeof(struct passwd)); > > Seems to work fine. Some apps that require threaded X11 now work, > specifically cdat (cdat.sf.net). I've updated the xfree86-base package in > fink cvs with these changes. Do they seem reasonable to you? > > -Jeff > > > > On Sat, 29 Dec 2001, Torrey Lyons wrote: > > > ---- Jeff Whitaker <js...@cd...> wrote: > > > > > > Has anyone tried compiling XFree86 on Darwin with > > threading activated? > > > > Not that I know of. > > > > > (I imagine this requires adding some stuff to > > darwin.cf) Before I try it > > > myself, I'd like to know if there's any reason why > > it shouldn't work. > > > > I don't know of any certain show stoppers, but you > > might want to make sure that none of the functions > > missing from Darwin's pthread implementation are > > needed. In any case, I would be very interested to > > hear what you discover. > > > > --Torrey > > > > > > -- > Jeffrey S. Whitaker Phone : (303)497-6313 > Meteorologist FAX : (303)497-6449 > NOAA/OAR/CDC R/CDC1 Email : js...@cd... > 325 Broadway Web : www.cdc.noaa.gov/~jsw > Boulder, CO, USA 80303-3328 Office : Skaggs Research Cntr 1D-124 > > > |