From: SourceForge.net <no...@so...> - 2007-08-10 12:50:39
|
Bugs item #1771400, was opened at 2007-08-10 06:06 Message generated for change (Comment added) made by bodewig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=377768&aid=1771400&group_id=23187 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface (example) Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: IgnoreValuesDifferenceListener Initial Comment: I created a custom IgnoreValueDifferenceListener and overrided the same in Diff Class e.g. diff.overrideDifferenceListener(new IgnoreSomeValuesDifferenceListener()); But there is a bug in overriden DetailedDiff's int differenceFound() method. In this method the call for allDifferences.add(difference) should be made in case RETURN_ACCEPT_DIFFERENCE:. As of now it adds all the differences to the list and does not cares for the differnces which need to be ignored. Please look into the DetailedDiff's overriden differenceFound method, I guess it needs to be modified. Thanks! Tarun Arora Email: ta...@sa... ---------------------------------------------------------------------- >Comment By: Stefan Bodewig (bodewig) Date: 2007-08-10 14:50 Message: Logged In: YES user_id=113148 Originator: NO DetailedDiff's differenceFound does not add Differences that are marked as identical (there is a return in the switch, so the allDifferences.add line is never reached). If adds differences that have been downgraded to similar, and this is correct. If you want your differences to be ignored completely, return RETURN_IGNORE_DIFFERENCE_NODES_IDENTICAL from your DifferenceListener. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=377768&aid=1771400&group_id=23187 |